-
Notifications
You must be signed in to change notification settings - Fork 34
wasm/deps: provide dependencies in bzlmod #934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
phlax
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think this is currently disabled/broken, otherwise i would say lets make it work bzlmod - but it would also require figuring what broke already
lgtm, thanks @mmorel-35
|
i take that back - it looks like it is tested/passing here - so then ... would be great to get this testing with bzlmod |
|
This is not related to bzlmod, It is not yet enabled here |
1d2ac27 to
a46f565
Compare
|
It also renames envoy-example-wasmcc to envoy_example_wasmcc to harmonize naming logic accross envoyproxy |
i prefer kebab-case - was gradually moving them to that - either way lets not rename in this pr can we get it to actually build with bzlmod? |
ac44a31 to
a46f565
Compare
|
Not entirely we still need to finish envoy first as it relies on it. |
|
Unintended deletion... |
a2db287 to
40b328d
Compare
|
Shall all modules be named with kebab-case and keep them as repo_name with actual name until new name is used everywhere ? modules : envoy-api, envoy-examples, envoy-example-wasmcc, envoy-mobile, envoy-build-config, envoy-toolshed |
477e2dc to
3b714d2
Compare
|
/retest |
40b43f5 to
accdbf1
Compare
|
sorry - i missed your question here - i was just meaning the examples - and in particular their filepath - which is used in envoy's docs etc i think for bzlmod we should go with the snake case convention that most others seem to use |
|
Alright I fixed it in toolshed, examples and envoy |
9b5b46a to
1ceb95e
Compare
6b74cd4 to
bb17dac
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
bb17dac to
1487f25
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
|
/retest |
Description
Provide dependencies in bzlmod