Skip to content

Conversation

@mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Nov 24, 2025

Description

Provide dependencies in bzlmod

phlax
phlax previously approved these changes Nov 24, 2025
Copy link
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is currently disabled/broken, otherwise i would say lets make it work bzlmod - but it would also require figuring what broke already

lgtm, thanks @mmorel-35

@phlax
Copy link
Member

phlax commented Nov 24, 2025

i take that back - it looks like it is tested/passing here - so then ... would be great to get this testing with bzlmod

@phlax phlax changed the title deps: provide dependencies in bzlmod wasm/deps: provide dependencies in bzlmod Nov 24, 2025
@mmorel-35
Copy link
Contributor Author

This is not related to bzlmod, It is not yet enabled here

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Nov 27, 2025

It also renames envoy-example-wasmcc to envoy_example_wasmcc to harmonize naming logic accross envoyproxy

@phlax
Copy link
Member

phlax commented Nov 27, 2025

It also renames

i prefer kebab-case - was gradually moving them to that - either way lets not rename in this pr

can we get it to actually build with bzlmod?

@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Nov 27, 2025

Not entirely we still need to finish envoy first as it relies on it.
I only test for bazel mod tidy --enable_bzlmod --lockfile_mode=update to pass now

@mmorel-35 mmorel-35 closed this Nov 27, 2025
@mmorel-35 mmorel-35 deleted the bzlmod-migration branch November 27, 2025 20:38
@mmorel-35 mmorel-35 restored the bzlmod-migration branch November 27, 2025 20:39
@mmorel-35 mmorel-35 reopened this Nov 27, 2025
@mmorel-35
Copy link
Contributor Author

Unintended deletion...

@mmorel-35 mmorel-35 requested a review from phlax November 28, 2025 16:34
@mmorel-35 mmorel-35 force-pushed the bzlmod-migration branch 3 times, most recently from a2db287 to 40b328d Compare November 29, 2025 17:16
@mmorel-35
Copy link
Contributor Author

mmorel-35 commented Nov 29, 2025

Shall all modules be named with kebab-case and keep them as repo_name with actual name until new name is used everywhere ?

modules : envoy-api, envoy-examples, envoy-example-wasmcc, envoy-mobile, envoy-build-config, envoy-toolshed
repo_names: envoy_api, envoy_examples, envoy_mobile, envoy_build_config, envoy_toolshed

@mmorel-35 mmorel-35 force-pushed the bzlmod-migration branch 4 times, most recently from 477e2dc to 3b714d2 Compare December 3, 2025 06:51
@mmorel-35
Copy link
Contributor Author

/retest

@mmorel-35 mmorel-35 force-pushed the bzlmod-migration branch 2 times, most recently from 40b43f5 to accdbf1 Compare December 4, 2025 18:12
@phlax
Copy link
Member

phlax commented Dec 4, 2025

sorry - i missed your question here - i was just meaning the examples - and in particular their filepath - which is used in envoy's docs etc

i think for bzlmod we should go with the snake case convention that most others seem to use

@mmorel-35
Copy link
Contributor Author

Alright I fixed it in toolshed, examples and envoy

@mmorel-35 mmorel-35 force-pushed the bzlmod-migration branch 10 times, most recently from 6b74cd4 to bb17dac Compare December 11, 2025 07:40
@mmorel-35
Copy link
Contributor Author

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants