Escape control characters when displaying VCL content #1637
+154
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VCL content currently allows control characters, which are stored without modification. This allows a malicious API token owner to inject control characters that manipulate the user’s terminal, potentially causing the CLI to display VCL code different from the code being executed. Fix this by escaping control sequences.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
VCL content currently allows control characters, which are stored without modification.
This allows injecting control characters that manipulate the user’s terminal, potentially causing the CLI to display VCL code different from the code being executed.
Fix this by escaping control sequences.
This is a low-impact issue, as it requires write access to the VCL.
All Submissions:
New Feature Submissions:
Changes to Core Features:
User Impact
Escape sequences are now displayed as escaped.
Are there any considerations that need to be addressed for release?