Fix confusion between public/private keys and signing/verification #1638
+16
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hardcoded Ed25519 key is a public key used to verify signatures on client keys returned by the API, not to sign anything. Rename the variable from `signingKey` to `verificationKey` to remove ambiguity, and update the comments to accurately reflect its purpose.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change summary
The hardcoded Ed25519 key is a public key used to verify signatures on client keys returned by the API, not to sign anything.
Rename the variable from
signingKeytoverificationKeyto remove ambiguity, and update the comments to accurately reflect its purpose.All Submissions:
User Impact
None.
Are there any considerations that need to be addressed for release?