Skip to content

Conversation

@a-maurice
Copy link
Contributor

Description

Provide details of the change, and generalize the change in the PR title above.

The GitHub api isn't returning the logs from previous attempts. We depend on an early step that can be missing from later attempts, so iterate over the attempts to find the logs.


Testing

Describe how you've tested these changes. Link any manually triggered Integration tests or CPP binary SDK Packaging Github Action workflows, if applicable.

Running locally.


Type of Change

Place an x the applicable box:

  • Bug fix. Add the issue # below if applicable.
  • New feature. A non-breaking change which adds functionality.
  • Other, such as a build process or documentation change.

Notes

  • Bug fixes and feature changes require an update to the Release Notes section of release_build_files/readme.md.
  • Read the contribution guidelines CONTRIBUTING.md.
  • Changes to the public API require an internal API review. If you'd like to help us make Firebase APIs better, please propose your change in a feature request so that we can discuss it together.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @a-maurice, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a bug in the log fetching mechanism for GitHub Actions. Previously, the system would only retrieve logs from the latest run attempt, which could lead to missing critical data if an important step occurred in an earlier, failed attempt. The updated logic now ensures that all run attempts are checked for logs, guaranteeing comprehensive data retrieval and improving the reliability of build status reporting.

Highlights

  • Log Fetching Improvement: Modified the script to iterate through all GitHub Actions run attempts when fetching logs. This addresses an issue where the default log location only provided logs from the last attempt, potentially missing crucial information from earlier attempts, especially for steps that might not be present in later retries.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • scripts/gha/report_build_status.py
    • Implemented a loop to iterate over all run attempts to fetch logs.
    • Updated the log URL construction to include the attempt number.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the script to fetch logs from multiple GitHub Actions workflow run attempts, addressing an issue where necessary information might be in earlier attempts and not in the latest one. The approach of iterating through attempts is correct, but the current implementation has a flaw in the loop range that causes it to skip the final attempt and fail to check any logs for single-attempt runs. I've provided a suggestion to correct the loop to ensure all attempts are processed.

@a-maurice a-maurice added the skip-release-notes Skip release notes check label Feb 10, 2026
@a-maurice a-maurice merged commit ec49e59 into main Feb 10, 2026
32 of 46 checks passed
@a-maurice a-maurice deleted the am-build_report branch February 10, 2026 18:29
@github-actions github-actions bot added the tests: in-progress This PR's integration tests are in progress. label Feb 10, 2026
@github-actions
Copy link

github-actions bot commented Feb 10, 2026

❌  Integration test FAILED

Requested by @a-maurice on commit ec49e59
Last updated: Tue Feb 10 13:17 PST 2026
View integration test log & download artifacts

Failures Configs
auth [TEST] [FAILURE] [Windows] [x64] [openssl]
(1 failed tests)  FirebaseAuthTest.TestSignInWithBadEmailFails
[TEST] [FAILURE] [tvOS] [macos] [tvos_simulator]
(1 failed tests)  FirebaseAuthTest.TestSignInWithBadEmailFails
firestore [TEST] [ERROR] [iOS] [macos] [All 2 ios_device]
[TEST] [ERROR] [tvOS] [macos] [tvos_simulator]
remote_config [TEST] [FLAKINESS] [Android] [1/3 os: ubuntu] [1/2 android_device: android_target]
(1 failed tests)  FirebaseRemoteConfigTest.TestAddOnConfigUpdateListener

Add flaky tests to go/fpl-cpp-flake-tracker

@github-actions github-actions bot added the tests: failed This PR's integration tests failed. label Feb 10, 2026
@firebase-workflow-trigger firebase-workflow-trigger bot removed the tests: in-progress This PR's integration tests are in progress. label Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-release-notes Skip release notes check tests: failed This PR's integration tests failed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants