refactor: decouple state setter from async callback execution

[firstof9]

Summary by CodeRabbit

• Bug Fixes

  • Improved websocket connection stability and state transition reliability, adding a thread-safe fallback for environments without a running event loop and ensuring transient error reasons are cleared on state change.

• Tests

  • Updated and expanded test coverage for websocket state management, including a new test validating the thread-safe fallback behavior and related state resets.

[coderabbitai]

📝 Walkthrough

Walkthrough

Refactors WebSocket state management: replaces an async state setter with a synchronous setter that schedules async callbacks via asyncio.create_task and falls back to loop.call_soon_threadsafe. Adds an internal async _set_state helper and tests for the threadsafe fallback and import cleanup.

Changes

Cohort / File(s)	Summary
WebSocket State Management Refactor openevsehttp/websocket.py	Converted async state setter to a synchronous setter that schedules the callback via asyncio.create_task with a fallback to loop.call_soon_threadsafe. Added async def _set_state(self, value) and migrated state transitions in running(), close(), keepalive(), and error paths to use the helper. Reset _error_reason consistently after scheduling.
Test Updates tests/test_websocket.py	Added test_state_setter_threadsafe_fallback to simulate asyncio.create_task raising RuntimeError and verify the fallback uses a mocked event loop's call_soon_threadsafe, and that _error_reason is cleared.
Test Cleanup tests/conftest.py	Removed an unused json import.
Test Rename tests/test_main.py	Renamed test_get_status to test_get_status_error.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 State hops from sync to async with cheer,
I queue the task when no loop is near.
If create_task trips and cannot run,
call_soon_threadsafe saves the fun.
Error reasons cleared — the run stays clear. ✨

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main refactoring work: decoupling the state setter from async callback execution, which is the primary change across multiple files.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch websocket-optimization

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Pylint (4.0.4)

tests/test_websocket.py

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Fix all issues with AI agents

In `@tests/test_websocket.py`:
- Around line 285-306: The test function test_state_setter_threadsafe_fallback
has an unused fixture parameter mock_callback; remove mock_callback from the
test signature so it becomes async def
test_state_setter_threadsafe_fallback(ws_client): to satisfy Ruff ARG001,
leaving ws_client (which already depends on the callback fixture) intact; update
any test references if necessary and run the linter to confirm the warning is
resolved.

[firstof9]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.