-
Notifications
You must be signed in to change notification settings - Fork 28
ug: offline-update: Use aklite CLI instead of aklite-offline #887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5200bdc to
4e44e9f
Compare
kprosise
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor suggestions. All vale warnings checked, and can be ignored.
Since v95, aklite CLI has full support for offline updates, and is the preferred method for doing so. It provides better compatibility with online updates behavior, especially in regards to exit codes, and does not require a feature to be enabled in the meta-subscriber-overrides. Signed-off-by: Andre Detsch <andre.detsch@foundries.io>
4e44e9f to
1df134f
Compare
Thanks, applied both suggestions |
vanmaegima
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
@kprosise feel free to merge when appropriate. |
| Make sure to check the :ref:`Offline Update Considerations`. | ||
|
|
||
| .. note:: | ||
| Since LmP v95, offline updates can be applied using the ``aktualizr-lite`` command-line interface, instead of the ``aklite-offline`` utility. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kprosise we have a standard on lmp release, let's at least use bold here
I'm not sure we have this rule in the linter, but would be good to have. Can you, please, handle this?
Since v95, aklite CLI has full support for offline updates, and is the preferred method for doing so. It provides better compatibility with online updates behavior, especially in regards to exit codes, and does not require a feature to be enabled in the meta-subscriber-overrides.
PR Template and Checklist
Please complete as much as possible to speed up the reviewing process.
You may delete items that are not relevant to your contribution.
Readiness and adding reviewers as appropriate is required.
All PRs should be reviewed by a technical writer/documentation team and a peer.
If effecting customers—which is a majority of content changes—a member of Customer Success must also review.
Readiness
Checklist
make linkcheck, and add redirects for any moved or deleted pages.-s, --signoff).-S, --gpg-sign).Comments
Any thing else that a maintainer/reviewer should know.
This could include potential issues, rational for approach, etc.