#5: Include JS and CSS, display CE IDs in page and list module while …#6
Open
steffenk wants to merge 1 commit intogeorgringer:masterfrom
Open
#5: Include JS and CSS, display CE IDs in page and list module while …#6steffenk wants to merge 1 commit intogeorgringer:masterfrom
steffenk wants to merge 1 commit intogeorgringer:masterfrom
Conversation
…dule while in debug mode
georgringer
requested changes
May 23, 2018
|
|
||
| namespace GeorgRinger\BackendDebug\Utility; | ||
|
|
||
| /*************************************************************** |
Owner
There was a problem hiding this comment.
wrong header, this is not part of the core
| protected function getCssCode() | ||
| { | ||
| return <<<EOT | ||
|
|
Owner
There was a problem hiding this comment.
just check the $GLOBALS['TYPO3_CONF_VARS']['BE']['debug'] there and include the CSS if set, no need to use additional JS
| * | ||
| * @return string | ||
| */ | ||
| protected function getContextCode() |
| 'className' => \GeorgRinger\BackendDebug\Xclass\SelectSingleElement::class, | ||
| ]; | ||
|
|
||
| $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_pagerenderer.php']['render-preProcess'][] = 'GeorgRinger\BackendDebug\Utility\PageRenderer->setup'; |
Owner
There was a problem hiding this comment.
use ::class for the class and please don't call it PageRenderer but place it to BackendDebug\Hooks\PageRendererHook
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…in debug mode