Add config dir to session options #15
Draft
+154
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
This PR adds support for a custom configuration directory (config_dir/configDir) option to session creation across all four SDKs (Python, Node.js, Go, and .NET). This enables users to isolate session configuration and state in a custom directory location instead of using the default.
Changes:
- Added
config_dir/configDirfield to session configuration types in all SDKs - Updated session creation logic to pass the config directory to the underlying session.create RPC call
- Added E2E tests for all four SDKs to verify sessions work correctly with custom config directories
- Added snapshot file for the new test case
Reviewed changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| test/snapshots/session/should_create_session_with_custom_config_dir.yaml | Snapshot file for the new test case verifying session creation with custom config directory |
| python/e2e/test_session.py | Added E2E test to verify session creation with custom config directory in Python SDK |
| python/copilot/types.py | Added config_dir field to SessionConfig type with documentation |
| python/copilot/client.py | Added logic to pass config_dir to session.create RPC call |
| nodejs/test/e2e/session.test.ts | Added E2E test to verify session creation with custom config directory in Node.js SDK |
| nodejs/src/types.ts | Added configDir field to SessionConfig interface with JSDoc documentation |
| nodejs/src/client.ts | Added logic to pass configDir to session.create RPC call |
| go/types.go | Added ConfigDir field to SessionConfig struct with documentation |
| go/e2e/session_test.go | Added E2E test to verify session creation with custom config directory in Go SDK |
| go/client.go | Added logic to pass configDir to session.create RPC call |
| dotnet/test/SessionTests.cs | Added E2E test to verify session creation with custom config directory in .NET SDK |
| dotnet/src/Types.cs | Added ConfigDir property to SessionConfig class with XML documentation |
| dotnet/src/Client.cs | Added ConfigDir parameter to CreateSessionRequest record and updated session creation logic |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
friggeri
previously approved these changes
Jan 15, 2026
devm33
force-pushed
the
devm33/config-dir
branch
from
46a9156 to
26a732f
Compare
| [Fact] | ||
| public async Task Should_Create_Session_With_Custom_Config_Dir() | ||
| { | ||
| var customConfigDir = Path.Combine(Ctx.HomeDir, "custom-config"); |
criemen
previously approved these changes
Jan 15, 2026
criemen
left a comment
criemen
left a comment
There was a problem hiding this comment.
stamping for merge conflict resolution
devm33
force-pushed
the
devm33/config-dir
branch
from
26a732f to
9d4fb55
Compare
| Assert.Matches(@"^[a-f0-9-]+$", session.SessionId); | ||
|
|
||
| // Verify config.json was written to the custom config dir | ||
| var configPath = Path.Combine(customConfigDir, "github-copilot", "config.json"); |
Collaborator
|
@devm33 You've got some CI failures here |
Member
Author
Yes this is blocked by a change in the runtime to fix connecting the config dir setting |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables setting an isolated configuration per session. Added to all SDKs.