Skip to content

Conversation

@timvaillancourt
Copy link
Collaborator

@timvaillancourt timvaillancourt commented Dec 28, 2022

Description

This PR forces the unique-key index to be used when gathering the min/max range of the unique key

This is to avoid possibilities of the optimizer picking a different index than we planned, discussed in more detail here. cc @morgo / @cyrinux

In case this PR introduced Go code changes:

  • contributed code is using same conventions as original code
  • script/cibuild returns with no formatting errors, build errors or unit test errors.

@timvaillancourt timvaillancourt marked this pull request as ready for review December 28, 2022 23:10
@timvaillancourt timvaillancourt requested review from a user and rashiq December 28, 2022 23:10
@morgo
Copy link
Contributor

morgo commented Dec 29, 2022

LGTM

@cyrinux
Copy link

cyrinux commented Dec 29, 2022

LGTM too 👍🏻

@timvaillancourt timvaillancourt added this to the v1.1.7 milestone Dec 7, 2023
@meiji163
Copy link
Contributor

meiji163 commented Dec 7, 2023

LGTM 🚀

@timvaillancourt timvaillancourt merged commit b22229f into github:master Dec 7, 2023
@timvaillancourt timvaillancourt deleted the readMigrationMinMaxValues-force-index branch December 7, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants