-
Notifications
You must be signed in to change notification settings - Fork 3.4k
ci: use mcp-conformance-action for conformance tests #1827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SamMorrowDrums
wants to merge
11
commits into
github:main
Choose a base branch
from
SamMorrowDrums:feat/conformance-action
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
ci: use mcp-conformance-action for conformance tests #1827
SamMorrowDrums
wants to merge
11
commits into
github:main
from
SamMorrowDrums:feat/conformance-action
+43
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace custom script/conformance-test with the reusable mcp-conformance-action GitHub Action. This provides: - Standardized MCP conformance testing across all MCP servers - Automatic comparison between PR branch and merge-base - Support for multiple configurations with different flags - Custom message support for dynamic toolset testing - Detailed conformance reports with timing comparisons - Artifact upload for test results All 16 original test configurations are preserved including the dynamic tool call tests for toolset management. Action: https://github.com/marketplace/actions/mcp-conformance-test Related: github#1826
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR replaces the custom script/conformance-test bash script with a reusable GitHub Action (mcp-conformance-action) to standardize conformance testing across MCP servers. The change streamlines the workflow definition while preserving all 16 test configurations.
Changes:
- Removed custom conformance test orchestration in favor of reusable GitHub Action
- Updated checkout action from v6 to v4.2.2 with commit SHA pinning
- Simplified workflow by moving test logic into external action
- Preserved all 16 test configurations in declarative JSON format
- Use checkout@v6 for consistency with other workflows - Pin mcp-conformance-action to SHA for security
Fixes step summary size limit issue by excluding full stderr logs from the markdown report. Logs are still available in the uploaded artifact.
Removes embedded JSON schemas from report to stay under GitHub's 1MB step summary limit. Full data is still available in the artifact.
Removes stderr log capture entirely for cleaner output and smaller artifacts.
Uses named pipes for reliable server startup detection instead of a blind sleep, fixing intermittent failures on slow startup.
d368fc1 to
433513d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replace the custom
script/conformance-testwith the reusable mcp-conformance-action GitHub Action.What this PR does
Benefits
custom_messagesTest configurations preserved
All 16 original configurations are maintained:
Related
Checklist