feat: durable runtime support #4200
Conversation
Moves runtime, event, and session service changes to a separate branch. These changes support deterministic execution required for durable integrations.
Summary of ChangesHello @marcusmotill, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
adk-bot
added
the
services
|
Response from ADK Triaging Agent Hello @marcusmotill, thank you for creating this PR! Could you please associate a GitHub issue with this PR? If there is no existing issue, could you please create one? In addition, could you please provide a testing plan in the PR description? This information will help reviewers to review your PR more efficiently. Thanks! |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a runtime module to abstract system primitives like time and UUID generation, which is a great step towards enabling deterministic execution for durable integrations. The changes in event.py and in_memory_session_service.py correctly adopt this new module. My review focuses on improving the maintainability and testability of the new runtime module by suggesting a way to centralize the default provider logic, which will simplify test setup and teardown.
| _time_provider: Callable[[], float] = time.time | ||
| _id_provider: Callable[[], str] = lambda: str(uuid.uuid4()) | ||
|
|
||
|
|
||
| def set_time_provider(provider: Callable[[], float]) -> None: | ||
| """Sets the provider for the current time. | ||
|
|
||
| Args: | ||
| provider: A callable that returns the current time in seconds since the | ||
| epoch. | ||
| """ | ||
| global _time_provider | ||
| _time_provider = provider | ||
|
|
||
|
|
||
| def set_id_provider(provider: Callable[[], str]) -> None: | ||
| """Sets the provider for generating unique IDs. | ||
|
|
||
| Args: | ||
| provider: A callable that returns a unique ID string. | ||
| """ | ||
| global _id_provider | ||
| _id_provider = provider | ||
|
|
||
|
|
||
| def get_time() -> float: | ||
| """Returns the current time in seconds since the epoch.""" | ||
| return _time_provider() | ||
|
|
||
|
|
||
| def new_uuid() -> str: | ||
| """Returns a new unique ID.""" | ||
| return _id_provider() |
There was a problem hiding this comment.
To improve maintainability and testability, it's better to avoid duplicating the default provider logic in the test files. I suggest introducing private module-level constants for the default providers and adding a reset_providers function. This provides a single source of truth for the default providers and simplifies test teardown logic, making the module more robust.
_default_time_provider: Callable[[], float] = time.time
_default_id_provider: Callable[[], str] = lambda: str(uuid.uuid4())
_time_provider: Callable[[], float] = _default_time_provider
_id_provider: Callable[[], str] = _default_id_provider
def def set_time_provider(provider: Callable[[], float]) -> None:
"""Sets the provider for the current time.
Args:
provider: A callable that returns the current time in seconds since the
epoch.
"""
global _time_provider
_time_provider = provider
def set_id_provider(provider: Callable[[], str]) -> None:
"""Sets the provider for generating unique IDs.
Args:
provider: A callable that returns a unique ID string.
"""
global _id_provider
_id_provider = provider
def reset_providers() -> None:
"""Resets the time and ID providers to their default implementations."""
global _time_provider, _id_provider
_time_provider = _default_time_provider
_id_provider = _default_id_provider
def get_time() -> float:
"""Returns the current time in seconds since the epoch."""
return _time_provider()
def new_uuid() -> str:
"""Returns a new unique ID."""
return _id_provider()| runtime.set_time_provider(time.time) | ||
| runtime.set_id_provider(lambda: str(uuid.uuid4())) |
There was a problem hiding this comment.
To avoid duplicating the default provider logic from the runtime module and to make the tests more robust against future changes, it's better to use a dedicated reset function. Following my suggestion on src/google/adk/runtime.py, you can call runtime.reset_providers() here. This centralizes the reset logic and ensures tests are always resetting to the correct default state.
| runtime.set_time_provider(time.time) | |
| runtime.set_id_provider(lambda: str(uuid.uuid4())) | |
| runtime.reset_providers() |
2 participants
Moves runtime, event, and session service changes to a separate branch. These changes support deterministic execution required for durable integrations.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
2. Or, if no issue exists, describe the change:
If applicable, please follow the issue templates to provide as much detail as
possible.
Problem:
A clear and concise description of what the problem is.
Solution:
A clear and concise description of what you want to happen and why you choose
this solution.
Testing Plan
Please describe the tests that you ran to verify your changes. This is required
for all PRs that are not small documentation or typo fixes.
Unit Tests:
Please include a summary of passed
pytestresults.Manual End-to-End (E2E) Tests:
Please provide instructions on how to manually test your changes, including any
necessary setup or configuration. Please provide logs or screenshots to help
reviewers better understand the fix.
Checklist
Additional context
Add any other context or screenshots about the feature request here.