Conversation
Collaborator
|
Wouldn't it be better to add the |
Member
Author
|
I considered that first but chose not to for two reasons:
|
Collaborator
And the topics pages. ;-) |
Abbe98
requested changes
Oct 22, 2024
Member
Abbe98
left a comment
There was a problem hiding this comment.
I would suggest moving the button to the right side, I think that patterns is a little bit more common and it makes sense for (most) mobile users.
- It currently interacts oddly with the footer, I think this is because it's inside of main(which I don't see why it should be).
- It currently appears when there is no scrollbar on the page(greenland is a good example)
- The scroll position at which it first shows seems inconsistent, shouldn't it be there as soon as you are no longer at the top?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on https://codepen.io/chriscoyier/pen/NWmzZXo
Fixes #377
(If #380 is merged, the tests will pass.)