Fix version mismatch between binary and git tags#31
Merged
Conversation
msaroufim
force-pushed
the
fix/version-mismatch
branch
2 times, most recently
from
835cffe to
1ce43ca
Compare
- Add build.rs that reads CLI_VERSION env var (defaults to "dev") - Update clap to use CLI_VERSION set by build script - Set Cargo.toml version to 0.0.0-dev as placeholder - CI passes git tag as CLI_VERSION when building releases Local builds show "dev", release builds show the tag version. Fixes #25
msaroufim
force-pushed
the
fix/version-mismatch
branch
from
1ce43ca to
286d3f2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add CI step to automatically sync Cargo.toml version from git tag before building, ensuring the binary always reports the correct version.
Fixes #25