fix stm32u0 data stride #3472
Open
fix stm32u0 data stride #3472
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zixun LI <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts TinyUSB’s STM32 FS device configuration so that STM32U0, which has a 1024-byte PMA but 32-bit access width, uses the correct data/address stride and access scheme.
Changes:
- In
tusb_option.h, special-cases STM32U0 so that althoughCFG_TUSB_FSDEV_PMA_SIZEis 1024, it uses the 32-bit FIFO data and address stride settings previously used only for 2048-byte PMA devices. - In
fsdev_common.h, similarly special-cases STM32U0 so that it uses the 32-bit PMA access scheme andFSDEV_BUS_32BITdefinitions instead of the generic 1024-byte (16-bit) scheme.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/tusb_option.h | Adjusts FSDEV FIFO data/address stride macros so STM32U0 with 1024-byte PMA uses 32-bit (stride 4) configuration instead of the generic 16-bit configuration. |
| src/portable/st/stm32_fsdev/fsdev_common.h | Updates PMA access scheme selection so STM32U0 is treated like a 32-bit bus device despite having a 1024-byte PMA. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
TinyUSB Average Code Size Metrics
Input files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
STM32U0 has 1024 byte PMA and 32bit access width.