Add tests for int and float JSON values and fix lexer regex #1688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sahelii
commented
Jan 16, 2026
sahelii
commented
- Add 42 and 3.14 to TEST_JSON_VALUES to test numeric JSON parsing
- Fix EnhancedJsonLexer regex to handle prefixes before numeric JSON values
- Resolves FIXME comment about missing int & float test coverage
- Add 42 and 3.14 to TEST_JSON_VALUES to test numeric JSON parsing - Fix EnhancedJsonLexer regex to handle prefixes before numeric JSON values - Resolves FIXME comment about missing int & float test coverage
The previous regex pattern -?\d only matched a single digit, which failed for multi-digit numbers and floats. Also changed .+ to .* to allow standalone numeric JSON values without requiring additional characters. This fixes the CI test failures for numeric JSON values with prefixes.
- Updated EnhancedJsonLexer regex to support standalone int/float JSON values - Added numbers to JSON start pattern detection - Handles edge cases where numbers appear in prefixes (e.g., while(1);) - Most test cases passing (346/350), some edge cases remain for complex prefixes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.