Resnet only use contiguous in training mode.#12977
Resnet only use contiguous in training mode.#12977sayakpaul merged 12 commits intohuggingface:mainfrom
Conversation
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
The failing test passes on But with this PR, that fails. Could you please check? |
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
|
The behaviour change has little impact on some models' precision; just changing the tolerance from |
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
|
But we need the tests to pass on our CI. |
|
I will check these failed tests. |
|
Hi @sayakpaul . The failed test seems network issue. Please check it. Thanks! |
|
Hi @sayakpaul . Please retrigger the CI. Thanks! |
|
It's so weird. The CI already passed in commit aa65c5c, but failed after update branch. @sayakpaul . Do you have any clue about it? |
Hi @sayakpaul . Would you please re-run the CI to see if the error disappears? Thanks! |
|
I see the lora tests also failed in #13003 |
| @require_hf_hub_version_greater("0.26.5") | ||
| @require_transformers_version_greater("4.47.1") | ||
| def test_save_load_dduf(self, atol=1e-4, rtol=1e-4): | ||
| def test_save_load_dduf(self, atol=1e-3, rtol=1e-3): |
There was a problem hiding this comment.
We shouldn't change it at the main test level. If a model test failing, we should override the method at the corresponding test class and relax tolerance.
There was a problem hiding this comment.
Hi @sayakpaul . It was my mistake. I've already fixed it. Please review the new change. Thanks!
|
Hi @sayakpaul . Would you please rerun the CI? I can pass the failed CI locally and the failed CI didn't show before. BTW, I saw many CI failed in the last commit in the main branch. Please let me know what need to be changed before merge. |
|
Can you push an empty commit? |
|
Hi @sayakpaul . I have updated the branch. Please rerun the CI. Thanks! |
|
Hi @sayakpaul . I relax the tol for |
|
Hi @sayakpaul. Is it okay to merge the PR? The new failed CI seems an accident because the previous commit can pass: |
Signed-off-by: jiqing-feng <jiqing.feng@intel.com>
3 participants
As the contiguous may have a negative impact on CPU performance, ResNet can only use it in training mode.
Fix #12975