[ENH] Add example and docs for GFO union grids and array-like search … #224
+59
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hello @smilingprogrammer It is custom to do so, because this way a maintainer has an easier job reviewing the new feature and to make sure the changes are all aligned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A simple example and doc for the feature Implemented in PR #217, for issue #123.
Related Issues
Type of Change
[BUG]- Bug fix (non-breaking change fixing an issue)[ENH]- New feature (non-breaking change adding functionality)[DOC]- Documentation changes[MNT]- MaintenanceHow was this solved?
Checklist
[BUG],[ENH],[DOC]or[MNT]make check(lint, format, isort)Testing
Additional Notes
NB: Was confused. Opened this new PR since it seems the project have been moved from
SimonBlake/Hyperactive.