Support multiple selections in both dd-select and dd-menu#58
Open
jeffhuys wants to merge 3 commits intojseppi:masterfrom
Open
Support multiple selections in both dd-select and dd-menu#58jeffhuys wants to merge 3 commits intojseppi:masterfrom
jeffhuys wants to merge 3 commits intojseppi:masterfrom
Conversation
Owner
|
Hey @jeffhuys, thanks for the PR! I have not had a chance to fully review it, but I wonder if it might not be simple to have separate directives for multi-select versions instead of overloading the single select versions. Perhaps directives that look like |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I love your dropdowns directive! In my case, I needed a dropdown menu that supports multiple selections. I didn't want to build the framework for dropdowns myself, so I forked your directive and added this functionality. I hope that my coding style is on par with yours. Please review my changes and let me know if you have any questions!