This repository was archived by the owner on Dec 15, 2025. It is now read-only.
[update] read string memory allocation optimization#650
Open
ddzrc wants to merge 1 commit intojson-iterator:masterfrom
Open
[update] read string memory allocation optimization#650ddzrc wants to merge 1 commit intojson-iterator:masterfrom
ddzrc wants to merge 1 commit intojson-iterator:masterfrom
Conversation
|
There will be a rare case to consider here: what if the input bytes will further get mutated? In this case, the output string will be changed since they shared the same underlying memory address. import (
"fmt"
jsoniter "github.com/json-iterator/go"
)
func main() {
var i1 = []byte(`"a"`)
var i2 = []byte(`"b"`)
var s1 string
var s2 string
jsoniter.Unmarshal(i1, &s1)
jsoniter.Unmarshal(i2, &s2)
i1[1] = 98
fmt.Println(s1, s2) // expect a b, got b b
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
before optimization benchmark test:
BenchmarkDecodeJsoniterStructMedium-4 195046 6399 ns/op
384 B/op 41 allocs/op
test by: https://github.com/json-iterator/go-benchmark/blob/master/src/github.com/json-iterator/go-benchmark/benchmark_medium_payload_test.go
after optimization benchmark test:
BenchmarkDecodeJsoniterStructMedium-4 219428 4998 ns/op
32 B/op 2 allocs/op
test by: https://github.com/json-iterator/go-benchmark/blob/master/src/github.com/json-iterator/go-benchmark/benchmark_medium_payload_test.go