Skip to content

Conversation

@taliandre49
Copy link

What this PR does / why we need it:
This PR updates PowerVS machine validation to include the s1122 system type, which is now available in newer PowerVS zones (e.g. dal14).

Upstream CAPI does not manage region or zone mappings; it is responsible for validating supported machine specifications. Without this change, cluster creation targeting newer zones fails validation due to unsupported system types.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes

Special notes for your reviewer:

  • This PR intentionally does not add or modify any region/zone mappings.
  • Region and zone awareness (e.g. dal14) is handled downstream by the OpenShift installer.
  • This change strictly updates PowerVS system type validation to reflect currently supported offerings.

/area provider/ibmcloud

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
    This PR does not change any image versions.

Release note:

Added support for the s1122 PowerVS system type in machine specification validation.

@k8s-ci-robot k8s-ci-robot added the area/provider/ibmcloud Issues or PRs related to ibmcloud provider label Jan 13, 2026
@linux-foundation-easycla
Copy link

CLA Missing ID CLA Not Signed

@netlify
Copy link

netlify bot commented Jan 13, 2026

Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!

Name Link
🔨 Latest commit e05da7d
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-cluster-api-ibmcloud/deploys/6966b610d627af0008f352ff
😎 Deploy Preview https://deploy-preview-2593.cluster-api-ibmcloud.sigs.k8s.io
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: taliandre49
Once this PR has been reviewed and has the lgtm label, please assign prajyot-parab for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

Welcome @taliandre49!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-ibmcloud 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-ibmcloud has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 13, 2026
@k8s-ci-robot
Copy link
Contributor

Hi @taliandre49. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 13, 2026
@Amulyam24
Copy link
Contributor

Hi @taliandre49, can you please sign the CNCF CLA?

@taliandre49
Copy link
Author

Hi @Amulyam24, CNCF CLA currently waiting approval by CLA manager!

Copy link
Contributor

@Karthik-K-N Karthik-K-N left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, Thanks for the PR

Without this change, cluster creation targeting newer zones fails validation due to unsupported system types.

Curious to know How are you creating the cluster, Is it using CAPIBM or any other way. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/provider/ibmcloud Issues or PRs related to ibmcloud provider cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants