-
Notifications
You must be signed in to change notification settings - Fork 95
Add s1122 to supported PowerVS system types #2593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
✅ Deploy Preview for kubernetes-sigs-cluster-api-ibmcloud ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: taliandre49 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Welcome @taliandre49! |
|
Hi @taliandre49. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Hi @taliandre49, can you please sign the CNCF CLA? |
|
Hi @Amulyam24, CNCF CLA currently waiting approval by CLA manager! |
Karthik-K-N
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, Thanks for the PR
Without this change, cluster creation targeting newer zones fails validation due to unsupported system types.
Curious to know How are you creating the cluster, Is it using CAPIBM or any other way. Thanks
What this PR does / why we need it:
This PR updates PowerVS machine validation to include the s1122 system type, which is now available in newer PowerVS zones (e.g. dal14).
Upstream CAPI does not manage region or zone mappings; it is responsible for validating supported machine specifications. Without this change, cluster creation targeting newer zones fails validation due to unsupported system types.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes
Special notes for your reviewer:
/area provider/ibmcloud
This PR does not change any image versions.
Release note: