Add support for Amazon Linux 2023. #12784
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
do-not-merge/release-note-label-needed
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: maaiika The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @maaiika. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
roles/bootstrap_os/tasks/amzn.yml
Outdated
| - name: Gather host facts to get ansible_distribution_version ansible_distribution_major_version | ||
| setup: | ||
| gather_subset: '!all' | ||
| filter: ansible_distribution_*version | ||
|
|
There was a problem hiding this comment.
I'm pretty sure this is already done elsewhere and you don't need to this in distro specific tasks
There was a problem hiding this comment.
Initially, I thought the same, but I added it only after encountering the error "'ansible_distribution_version is undefined'".
There was a problem hiding this comment.
This should change with #12830 which centralizes fact setup to avoid doing it everywhere.
| - name: Enable selinux-ng repo for Amazon Linux for container-selinux | ||
| command: amazon-linux-extras enable selinux-ng | ||
| when: | ||
| - (ansible_distribution_version | float) == 2 |
There was a problem hiding this comment.
No reason to add additional restriction here.
There was a problem hiding this comment.
The amazon-linux-extras system used in Amazon Linux 2 does not exist in Amazon Linux 2023.
see https://docs.aws.amazon.com/AmazonECS/latest/developerguide/al2-to-al2023-ami-transition.html.
roles/bootstrap_os/tasks/amzn.yml
Outdated
| when: epel_enabled | ||
| when: | ||
| - epel_enabled | ||
| - (ansible_distribution_version | float) == 2 |
There was a problem hiding this comment.
same here (unless you're excluding the 2023 version ? It's unclear)
There was a problem hiding this comment.
The amazon-linux-extras system used in Amazon Linux 2 does not exist in Amazon Linux 2023 ,also have no epel package.
see https://docs.aws.amazon.com/AmazonECS/latest/developerguide/al2-to-al2023-ami-transition.html.
| mode: '0644' | ||
| when: | ||
| - "{{ ansible_distribution == 'Amazon' }}" | ||
| - "{{ ansible_distribution_major_version == '2023' }}" |
There was a problem hiding this comment.
IMO this should be more apprioriate in distro specific tasks since it's a workaround for a distro bug.
There was a problem hiding this comment.
Sure, the issue remains unresolved.
k8s-ci-robot
added
ok-to-test
roles/bootstrap_os/tasks/amzn.yml
Outdated
| - name: Gather host facts to get ansible_distribution_version ansible_distribution_major_version | ||
| setup: | ||
| gather_subset: '!all' | ||
| filter: ansible_distribution_*version | ||
|
|
There was a problem hiding this comment.
Initially, I thought the same, but I added it only after encountering the error "'ansible_distribution_version is undefined'".
roles/bootstrap_os/tasks/amzn.yml
Outdated
| when: epel_enabled | ||
| when: | ||
| - epel_enabled | ||
| - (ansible_distribution_version | float) == 2 |
There was a problem hiding this comment.
The amazon-linux-extras system used in Amazon Linux 2 does not exist in Amazon Linux 2023 ,also have no epel package.
see https://docs.aws.amazon.com/AmazonECS/latest/developerguide/al2-to-al2023-ami-transition.html.
| mode: '0644' | ||
| when: | ||
| - "{{ ansible_distribution == 'Amazon' }}" | ||
| - "{{ ansible_distribution_major_version == '2023' }}" |
There was a problem hiding this comment.
Sure, the issue remains unresolved.
| - name: Enable selinux-ng repo for Amazon Linux for container-selinux | ||
| command: amazon-linux-extras enable selinux-ng | ||
| when: | ||
| - (ansible_distribution_version | float) == 2 |
There was a problem hiding this comment.
The amazon-linux-extras system used in Amazon Linux 2 does not exist in Amazon Linux 2023.
see https://docs.aws.amazon.com/AmazonECS/latest/developerguide/al2-to-al2023-ami-transition.html.
The condition for selecting curl was previously incorrect: it used "A AND B", which fails for Amazon (not 2023) or version 2023 (not Amazon). Don't know if the latter exists, but this change supports potential future Amazon Linux versions.
Co-authored-by: Max Gautier <[email protected]>
3 participants
What type of PR is this?
What this PR does / why we need it:
Which issue(s) this PR fixes:
Special notes for your reviewer:
Does this PR introduce a user-facing change?