-
Notifications
You must be signed in to change notification settings - Fork 297
Add auto-generated API documentation using crd-ref-docs #2417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add auto-generated API documentation using crd-ref-docs #2417
Conversation
✅ Deploy Preview for kubernetes-sigs-nfd ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ArangoGutierrez The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This commit addresses issue kubernetes-sigs#2090 by adding auto-generated API reference documentation for the NFD CRDs using elastic/crd-ref-docs. Changes: - Add Makefile target 'generate-api-docs' to generate API documentation - Add crd-ref-docs configuration at hack/crd-ref-docs/config.yaml - Generate initial API reference for api/nfd/v1alpha1 at docs/reference/nfd-api-reference.md The generated documentation includes all NFD Custom Resource types: - NodeFeature / NodeFeatureSpec - NodeFeatureRule / NodeFeatureRuleSpec / Rule - NodeFeatureGroup / NodeFeatureGroupSpec / GroupRule - Supporting types: FeatureMatcher, MatchExpression, etc. Note: api/image-compatibility types are not CRDs and thus not documented by this tool (they lack kubebuilder markers).
ad6381a to
0797c5d
Compare
|
/assign @marquiz |
|
@ArangoGutierrez: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does
This PR addresses issue #2090 by adding auto-generated API reference documentation for the NFD CRDs using elastic/crd-ref-docs.
Changes
generate-api-docsto generate API documentationhack/crd-ref-docs/config.yamlapi/nfd/v1alpha1atdocs/reference/nfd-api-reference.mdUsage
Regenerate API docs anytime with:
Generated Documentation
The generated documentation includes all NFD Custom Resource types:
NodeFeature/NodeFeatureSpecNodeFeatureRule/NodeFeatureRuleSpec/RuleNodeFeatureGroup/NodeFeatureGroupSpec/GroupRuleFeatureMatcher,MatchExpression, etc.Note
The
api/image-compatibilitytypes are not Kubernetes CRDs (they lack+kubebuildermarkers), socrd-ref-docsdoesn't generate documentation for them. If documentation is needed for those types, a different approach would be required./kind documentation