-
Notifications
You must be signed in to change notification settings - Fork 965
Update "rel.k8s.io/k8s-release-cal" shortlink to point to Kubernetes release calendar #8945
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
/assign priyankasaggu11929 For approval based on #8945 (comment) |
|
/approve /hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dipesh-rawat, Priyankasaggu11929 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm I think this was the original intention, but am not sure if there are other implications for the existing calendar. We may want to keep it around with a different link perhaps, but for now I don't see an issue myself. LGTM and holding just in case. |
jenshu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if anyone is already using the existing links, but maybe it would be clearer if we renamed them to:
- k8s-sig-release-cal -> SIG Release calendar
- k8s-release-team-cal -> Release Team calendar
Description
This change updates the release calendar shortlink (
https://rel.k8s.io/k8s-release-cal) so that it points to the Kubernetes v1.xx release team calendar, matching the original behavior of the bitly link.Old
https://bit.ly/k8s-release-cal -> https://calendar.google.com/calendar/embed?src=agst.us_b07popf7t4avmt4km7eq5tk5ao%40group.calendar.google.com
New (post this PR merge)
https://rel.k8s.io/k8s-release-cal -> https://calendar.google.com/calendar/embed?src=agst.us_b07popf7t4avmt4km7eq5tk5ao%40group.calendar.google.com
/cc @katcosgrove @fsmunoz @rytswd