feat(Designcard): support React icons in resource list with link hover styling #1236
+17
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rajesh-Nagarajan-11 <[email protected]>
1 task
ritzorama
reviewed
Jan 16, 2026
Contributor
ritzorama
left a comment
ritzorama
left a comment
There was a problem hiding this comment.
Please address this related lint check issue - https://github.com/layer5io/sistent/actions/runs/21070399837/job/60598232801?pr=1237#step:5:1021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR enhances the Design Card resource list by replacing -based icons with support for React icon components.
Previously, Icon rendered as![]()
could not inherit color or respond to hover states, limiting theme consistency and interactivity. By allowing icons to be passed as React components (SVG-based), icons can now inherit currentColor, enabling proper hover color changes and improved flexibility.
Icons respond to link hover state
⏳ These PRs need to be merged after the new Sistent version is released :
Signed commits