feat: AWS Lambda CDK deployment adapter#282
Open
aheissenberger wants to merge 5 commits intolazarv:mainfrom
Open
feat: AWS Lambda CDK deployment adapter#282aheissenberger wants to merge 5 commits intolazarv:mainfrom
aheissenberger wants to merge 5 commits intolazarv:mainfrom
Conversation
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds comprehensive test coverage and integration tests for the AWS Lambda adapter, along with test fixtures and example applications demonstrating both streaming and buffered modes.
- Implements unit tests for adapter core components (ReactServerFramework, handlers, utilities)
- Adds integration tests with real fixture applications to validate end-to-end Lambda deployment
- Includes extensive debugging documentation and test infrastructure setup
Reviewed Changes
Copilot reviewed 51 out of 52 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react-server-adapter-aws-lambda/vitest.config.mjs | Vitest configuration for test runner and coverage reporting |
| packages/react-server-adapter-aws-lambda/test/setup.mjs | Global test setup with AWS Lambda runtime mocks |
| packages/react-server-adapter-aws-lambda/test/shared.test.mjs | Unit tests for shared adapter logic and ReactServerFramework |
| packages/react-server-adapter-aws-lambda/test/adapter.test.mjs | Tests for adapter configuration and handler path selection |
| packages/react-server-adapter-aws-lambda/test/utils.test.mjs | Tests for CDK utility functions (static asset routing) |
| packages/react-server-adapter-aws-lambda/test/streaming.test.mjs | Tests for streaming handler exports and initialization |
| packages/react-server-adapter-aws-lambda/test/streaming-timeout.integration.test.mjs | Integration tests validating Lambda timeout prevention via callbackWaitsForEmptyEventLoop |
| packages/react-server-adapter-aws-lambda/test/integration.test.mjs | Full integration tests building and executing handlers with real React Server apps |
| packages/react-server-adapter-aws-lambda/test/fixtures/minimal-app/* | Minimal React Server app fixture with streaming support for integration testing |
| packages/react-server-adapter-aws-lambda/test/fixtures/minimal-app-buffered/* | Minimal buffered-mode fixture for testing non-streaming Lambda handler |
| packages/react-server-adapter-aws-lambda/test/README.md | Comprehensive testing documentation with debug logging instructions |
| packages/react-server-adapter-aws-lambda/package.json | Package configuration with test scripts and dependencies |
| packages/react-server-adapter-aws-lambda/cdk/utils.mjs | Utility function for generating static asset routing tables |
| packages/react-server-adapter-aws-lambda/README.md | User-facing documentation for adapter features and configuration |
| examples/hello-world-aws-lambda/* | Full-featured example application demonstrating AWS Lambda deployment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
packages/react-server-adapter-aws-lambda/cdk/react-server-stack.mjs
Outdated
Show resolved
Hide resolved
packages/react-server-adapter-aws-lambda/cdk/react-server-stack.mjs
Outdated
Show resolved
Hide resolved
packages/react-server-adapter-aws-lambda/cdk/react-server-stack.mjs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a new simplified attempt to create an adapter for AWS Lambda #30
This version supports only CDK as the deployment option.
Features:
requires #281