-
Notifications
You must be signed in to change notification settings - Fork 281
Fix admin privilege dialog not opening from actions menu #5655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix admin privilege dialog not opening from actions menu #5655
Conversation
|
👋 Thanks for contributing! We will assign a reviewer within the next two weeks. In the meantime, please ensure that:
We'll be in touch! 😊 |
|
Hi again @sharma-anushka, thank you. Before we assign a maintainer, I will first invite the community review. |
|
📢 ✨ Community Review guidance for both authors and reviewers. |
|
Hi @LightCreator1007 - I think you mentioned interest to collaborate on this issue - you're welcome to review. Thanks both. |
| <VListTile | ||
| v-if="user.is_admin" | ||
| data-test="removeadmin" | ||
| @mousedown.stop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its better to use @click.stop as it offers clearer intent and better alignment with the actual behavior we are aiming to protect against. Also, the mousedown event fires much earlier compare to the click.stop that fires after the full click is realized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it . Ill make the changes. Thankyou for letting me know in detail.
| <VListTile | ||
| v-else | ||
| data-test="addadmin" | ||
| @mousedown.stop |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See my comment here
akolson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sharma-anushka! Great work on this and manual QA checks out. I have however left a few comments for your action. Thanks
|
Hi @akolson , Ive made the necessary changes, you may have a look. |
akolson
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @sharma-anushka
Description
This PR fixes an issue where the
Add / Remove admin privilegesdialog did not open upon clicking theAdd admin privilegesaction inside the Users tab.What was changed
Adjusted click handling so the menu interaction no longer blocks dialog rendering
Preserved existing behavior and API of UserActionsDropdown and UserPrivilegeModal
Why this works
The dialog state is now set at the correct time in Vue’s render cycle
Prevents the menu component from swallowing or cancelling the dialog trigger
Matches the expected UX: clicking the
Add admin privilagesreliably opens the confirmation dialogTesting
Manually verified:
Email / Deactivate / Delete actions still behave as expected
Screen.Recording.2026-01-20.at.11.23.35.PM.mov
Related issue
Fixes #5645