Skip to content

fix: improve error message for exhausted blinded path route hints#4398

Open
okekefrancis112 wants to merge 1 commit intolightningdevkit:mainfrom
okekefrancis112:specific_routing_error_message
Open

fix: improve error message for exhausted blinded path route hints#4398
okekefrancis112 wants to merge 1 commit intolightningdevkit:mainfrom
okekefrancis112:specific_routing_error_message

Conversation

@okekefrancis112
Copy link
Contributor

This PR improves the routing error returned when attempting to pay a blinded (private) recipient and no route can be found. For Payee::Blinded, there is no public node ID or public graph path to the destination, meaning blinded path route hints are the only way to reach the payee. Previously, exhausting all provided blinded path hints resulted in the generic error “Failed to find a path to the given destination,” which is misleading. This change returns a more specific error indicating that all blinded path route hints were exhausted, while leaving behavior unchanged for Payee::Clear, where routing may still succeed via the public network graph even if route hints fail.

Closes: #4308

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Feb 8, 2026

I've assigned @valentinewallace as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@codecov
Copy link

codecov bot commented Feb 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.02%. Comparing base (2424c4a) to head (2e8ad3c).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4398      +/-   ##
==========================================
- Coverage   86.03%   86.02%   -0.01%     
==========================================
  Files         156      156              
  Lines      103092   103105      +13     
  Branches   103092   103105      +13     
==========================================
+ Hits        88694    88698       +4     
- Misses      11885    11893       +8     
- Partials     2513     2514       +1     
Flag Coverage Δ
tests 86.02% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Specific routing error message for "cant try again because all the route hints to the node have been tried"

2 participants