fix: improve error message for exhausted blinded path route hints#4398
Open
okekefrancis112 wants to merge 1 commit intolightningdevkit:mainfrom
Open
fix: improve error message for exhausted blinded path route hints#4398okekefrancis112 wants to merge 1 commit intolightningdevkit:mainfrom
okekefrancis112 wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
I've assigned @valentinewallace as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4398 +/- ##
==========================================
- Coverage 86.03% 86.02% -0.01%
==========================================
Files 156 156
Lines 103092 103105 +13
Branches 103092 103105 +13
==========================================
+ Hits 88694 88698 +4
- Misses 11885 11893 +8
- Partials 2513 2514 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the routing error returned when attempting to pay a blinded (private) recipient and no route can be found. For
Payee::Blinded, there is no public node ID or public graph path to the destination, meaning blinded path route hints are the only way to reach the payee. Previously, exhausting all provided blinded path hints resulted in the generic error “Failed to find a path to the given destination,” which is misleading. This change returns a more specific error indicating that all blinded path route hints were exhausted, while leaving behavior unchanged forPayee::Clear, where routing may still succeed via the public network graph even if route hints fail.Closes: #4308