Skip to content

Relax validation on the postgres service address setting #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tnull merged 2 commits into from
Feb 9, 2026
Merged

Relax validation on the postgres service address setting #91

tnull merged 2 commits into from
Feb 9, 2026
+6 −18

Conversation

@tankyleo
Copy link
Contributor

@tankyleo tankyleo commented Feb 4, 2026 


    Relax validation on the postgres service address setting

    We previously parsed the postgres service address setting into a
    `std::net::SocketAddr`, which was overly restrictive, and
    prevented the use of hostnames for that setting.

    The postgres service address is logged on startup, so the user can check
    that the service address is correctly configured in case of a failure
    to connect to the postgres database on startup.

@tankyleo
Relax validation on the postgres service address setting
b7c7406 
We previously parsed the postgres service address setting into a
`std::net::SocketAddr`, which was overly restrictive, and
prevented the use of hostnames for that setting.

The postgres service address is logged on startup, so the user can check
that the service address is correctly configured in case of a failure
to connect to the postgres database on startup.
@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Feb 4, 2026 •
edited
Loading

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@tankyleo tankyleo requested review from tnull and removed request for joostjager February 4, 2026 21:14
tnull
tnull reviewed Feb 5, 2026
View reviewed changes
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In #73 we made the same change for bind_address. We should probably revert that, too, no?

@tankyleo
Relax validation on the bind address setting
945b348 
We previously parsed the bind address setting into a
`std::net::SocketAddr`, which was overly restrictive, and prevented the
use of hostnames for that setting.

In case of a failure to bind to the specified address, we make sure to
report the bind address in the error message so the user understands
which address we tried to bind to.
@tankyleo tankyleo requested a review from tnull February 9, 2026 07:22
@tnull tnull merged commit e4c8359 into lightningdevkit:main Feb 9, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tnull tnull tnull approved these changes

+1 more reviewer

@tsmith123 tsmith123 tsmith123 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tankyleo @ldk-reviews-bot @tnull @tsmith123