-
Notifications
You must be signed in to change notification settings - Fork 27
ci: Update release workflow for npm OIDC authentication and bump up node version #273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request updates the npm publishing workflow to use OIDC (OpenID Connect) authentication instead of token-based authentication, and upgrades Node.js to version 24 across all CI workflows.
Changes:
- Migrated npm publishing from token-based authentication to OIDC trusted publishing
- Upgraded Node.js from version 18 to version 24 across all GitHub Actions workflows
- Added npm provenance configuration to package.json
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| release.sh | Simplified script to use OIDC authentication, removing manual NPM_TOKEN handling |
| package.json | Added publishConfig section with provenance settings for npm trusted publishing |
| .github/workflows/release.yml | Added OIDC permissions, registry-url configuration, and Node.js 24 upgrade |
| .github/workflows/pull-request.yml | Updated Node.js version from 18 to 24 across all jobs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
thomson-t
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaissica12 can you rebase the changes on the latest main, please?
There was an issue with the iOS PR build due to the simulator version being unavailable, and it's been fixed now.
90a6bb4 to
39f28f5
Compare
remove duplicate access flag Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@thomson-t thanks for letting me know, rebased the changes on the latest main. |
Summary
LTS24.xTesting Plan
Master Issue
Closes https://go/j/SDKE-683