-
Notifications
You must be signed in to change notification settings - Fork 34
SSO Cloud #391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
SSO Cloud #391
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughAdds a new Single Sign-On (SSO) documentation page, updates project/workspace member cross-reference links, and consolidates authentication entries in the sidebar to reference the unified SSO doc. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/core-concepts/projects/manage-project-members.mdx (1)
158-166: Duplicate section detected.The "How users join projects" section (lines 158-166) is a duplicate of lines 119-127. This appears to be an accidental copy that should be removed.
🗑️ Proposed fix: Remove duplicate section
This audit trail helps project admins monitor membership changes and verify that access permissions are correct. Activity is retained for project history. -## How users join projects - -Users can become project members in two different ways, and understanding both helps you manage your project team effectively. - -**Direct project membership** is where you specifically invite users to your project and assign them roles. These members have access only to the projects you've added them to, and you have full control over their permissions. - -**Teamspace-based membership** happens automatically when your project is linked to a [Teamspace](/core-concepts/workspaces/teamspaces). All members of that teamspace automatically receive `Member` access to your project, making it perfect for teams that collaborate across multiple projects. - -Users can have both types of access simultaneously. When this happens, Plane automatically applies whichever role gives them higher permissions. For example, if someone is a `Guest` on your project but joins a linked teamspace, they're automatically upgraded to `Member` access. If they're already an `Admin`, they keep their `Admin` role. - ## See also - [Manage workspace members](/core-concepts/workspaces/members)
🤖 Fix all issues with AI agents
In `@docs/authentication/sso.mdx`:
- Around line 32-37: Remove the duplicated instruction "Copy the **TXT record
value**" — keep it only once between Step 4 and Step 5 in the SSO setup text;
specifically, edit the steps that currently read "Step 4: In the **Verify your
domain** modal that appears, copy the **TXT record value**." and "Step 5: Copy
the **TXT record value**." so that only one of those lines remains (either keep
the detailed Step 4 or collapse Step 5 into a single continuation line).
Description
Type of Change
Screenshots and Media (if applicable)
Test Scenarios
References
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.