Test /messages backfill over federation#816
Merged
MadLittleMods merged 15 commits intomainfrom Nov 18, 2025
Merged
Conversation
MadLittleMods
commented
Nov 10, 2025
MadLittleMods
commented
Nov 11, 2025
| // This is the default limit in the Matrix spec so it's bound to be lower than | ||
| // the number of messages that are backfilled. | ||
| messagesRequestLimit: 10, | ||
| }, |
Collaborator
Author
There was a problem hiding this comment.
It looks like Dendrite is failing for this new join test ❌
room_messages_test.go:456: Fetched 0 events from the `/messages` endpoint that included events -1 to -1
room_messages_test.go:478: expected 20 events in timeline (got 0)
Actual events ('+' = found expected items):
Expected events ('?' = missing expected items):
0: ? $bHuD6zz85kH7VaJ5pLIgKOzXRiahEFFLbF_USmk_RQ8
1: ? $d_-e9gIkd_OBa9JcEx1lmkpRDq1Htq-ibNsCJjoVN60
2: ? $YV63PCoC_ueNAg9yreAvMdN50nGhRvJTUPU9DzaXMFs
3: ? $CE_XewxnoG7Ym6grECxIiNVxAyHsgwUKmKMCuwPiVhw
4: ? $MXkopFxCpIriJ07-IOk4eg2RddrdNnVHYWK6hcfEMcY
5: ? $Z1GZo9gZSi3_GXlZTJJ6tcJdG7iNs1jUf0DWs-Wtjvk
6: ? $6RYbWw37yU5_MPiuztqWgXOshFDvzxoy5VCHenyY41A
7: ? $Q2NvrVy7zph0vbxL5Mv10IppFijqq90F83WHw896_-A
8: ? $y2wEYtym8T8hu6dEqdMTm6E5-BrsbOOYgVQJXOY4GC0
9: ? $EOL1sQAqOiUw1GNqOISEZzzom2nWTsbG7KyJm_QLD-0
10: ? $YXVTeLsDBzDDEoI3tfQs2TS0p2vxJuDFMuHb89t0pHk
11: ? $zbPg7V-QZKNWATQVElImL0B6bO54k8EfOd-eXGWloBk
12: ? $Ls_1o7Ju4o8CLXpZf6S_IKEKg7w0da2y2FDU35E4S48
13: ? $2I-OHwEBs7xm7kBPUd8Q0olijwpSLWiZTlJ9qqm-OEM
14: ? $dZK_UrEDtRHHhf5zkAhiFfIK05UH04-f7K8H8OwLoUI
15: ? $ffaA5N-j3WcBna1gy5xC-w61ZS-uW2gDvh0WHKLyiWk
16: ? $42NunPvr3F22JJZj5nEgIxp0wACR0K7ORQC4JAUlSsU
17: ? $sDKr6ga7T6Ua7FwItBsP4s0ASM5F2jtWY305T0WT_ho
18: ? $MzpPleiMArvGxxOiYxiDn_acoQpYysUhzW-gABw4LxU
19: ? $gU07PHxUSdDv5HDM7m9QiTMh_TgMX1KN7v3lZA_JUro
Feels like something broken in Dendrite if it can't handle the most simple case 🤔
I don't think this is a very specific Synapse test although the spec doesn't give any specific server behavior to abide by so it's not surprising that another homeserver implementation would do something else.
devonh
reviewed
Nov 12, 2025
devonh
reviewed
Nov 12, 2025
devonh
requested changes
Nov 18, 2025
Contributor
devonh
left a comment
There was a problem hiding this comment.
Just a few small things. Otherwise this looks good @MadLittleMods
Thanks for taking the time to add this coverage.
devonh
approved these changes
Nov 18, 2025
2 tasks
Collaborator
Author
|
Thanks for the review @devonh 🦐 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test
/messagesbackfill over federationSpawning from wanting to give an accurate reply on element-hq/synapse#19153
But this is just general missing test coverage that's good to have.
There are many more scenarios to test here but Synapse doesn't behave well so it's tough to introduce something that will just fail. Something for the future ⏩
Dev notes
A long time ago, I also tried to add some
/messagesfederation tests: #443Also based off of #801
Cloning slices:
Pull Request Checklist
Signed-off-by: Eric Eastwood [email protected]