Fix ByteBufferBsonOutput buffer caching logic.#1683
Merged
vbabanin merged 2 commits intomongodb:mainfrom Apr 18, 2025
Merged
Conversation
Replaced getNextByteBuffer with getCurrentByteBuffer in writeOnBuffers to correct buffer state management. getNextByteBuffer failed to update currentByteBuffer, causing encoding errors. JAVA-5816
vbabanin
requested review from
a team and
stIncMale
and removed request for
a team
stIncMale
approved these changes
Apr 18, 2025
| if (currentByteBuffer == null) { | ||
| currentByteBuffer = getByteBufferAtIndex(curBufferIndex); | ||
| } | ||
|
|
Member
There was a problem hiding this comment.
[optional]
Was this change intentional or accidental? I ma pointing it out just in case it was an accident. If not, feel free to merge.
Member
Author
There was a problem hiding this comment.
The change was intentional - i thought visually separating the branches (after the recent changes in #1675) might help make the logic a bit more apparent. Thank you for flagging it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #1651 missed changes introduced in PR #1675, leading to incorrect buffer handling in
ByteBufferBsonOutput.This PR merges both changes to resolve the issue.
Changes
getNextByteBufferwithgetCurrentByteBufferinwriteOnBuffersto correct buffer state management, becausegetNextByteBufferfailed to updatecurrentByteBuffer, causing encoding errors.JAVA-5816