[JAVA-6060] Reduce global state by grouping internal settings by nhachicha · Pull Request #1864 · mongodb/mongo-java-driver

nhachicha · 2026-01-19T14:05:09Z

Replace static recordEverything with instance-based InternalMongoClientSettings configuration.
Moved InternalConnectionPoolSettings under InternalMongoClientSettings

…ntSettings configuration

Copilot

Pull request overview

This pull request refactors internal MongoDB client configuration by replacing static global state with instance-based settings. The main change centralizes internal settings into a new InternalMongoClientSettings class that encapsulates both connection pool settings and the recordEverything flag, which was previously a static variable in InternalStreamConnection.

Changes:

Introduced InternalMongoClientSettings class to encapsulate internal configuration including InternalConnectionPoolSettings and recordEverything flag
Created InternalMongoClients factory classes for both sync and reactive drivers to handle client creation with internal settings
Removed static recordEverything field from InternalStreamConnection in favor of instance-based configuration
Updated test classes to use new factory methods and pass internal settings explicitly instead of relying on global state

Reviewed changes

Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
driver-core/src/main/com/mongodb/internal/connection/InternalMongoClientSettings.java	New immutable settings class containing internal connection pool settings and recordEverything flag
driver-core/src/main/com/mongodb/internal/connection/InternalStreamConnection.java	Removed static recordEverything field and added instance field; updated constructors to accept recordEverything parameter
driver-core/src/main/com/mongodb/internal/connection/InternalStreamConnectionFactory.java	Added recordEverything parameter to constructors and passed it to InternalStreamConnection
driver-core/src/main/com/mongodb/internal/connection/DefaultClusterFactory.java	Updated to use InternalMongoClientSettings instead of InternalConnectionPoolSettings
driver-core/src/main/com/mongodb/internal/connection/DefaultClusterableServerFactory.java	Replaced InternalConnectionPoolSettings parameter with InternalMongoClientSettings
driver-core/src/main/com/mongodb/internal/connection/LoadBalancedClusterableServerFactory.java	Replaced InternalConnectionPoolSettings parameter with InternalMongoClientSettings
driver-sync/src/main/com/mongodb/client/MongoClients.java	Refactored to delegate to InternalMongoClients with default internal settings
driver-sync/src/main/com/mongodb/client/internal/InternalMongoClients.java	New factory class for creating MongoClient instances with custom internal settings
driver-sync/src/main/com/mongodb/client/internal/Clusters.java	Added overload accepting InternalMongoClientSettings
driver-sync/src/main/com/mongodb/client/internal/MongoClientImpl.java	Removed createCluster and getStreamFactory helper methods (moved to InternalMongoClients)
driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/MongoClients.java	Refactored to delegate to InternalMongoClients with default internal settings
driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/internal/InternalMongoClients.java	New factory class for creating reactive MongoClient instances with custom internal settings
driver-sync/src/test/functional/com/mongodb/client/AbstractClientSideOperationsTimeoutProseTest.java	Added createMongoClientWithInternalSettings method to support tests requiring internal settings
driver-sync/src/test/functional/com/mongodb/client/ClientSideOperationTimeoutProseTest.java	Implemented createMongoClientWithInternalSettings method
driver-sync/src/test/functional/com/mongodb/client/AbstractClientMetadataProseTest.java	Removed static recordEverything setup/teardown
driver-sync/src/test/functional/com/mongodb/client/ClientMetadataProseTest.java	Updated to use InternalMongoClients with recordEverything enabled
driver-sync/src/test/functional/com/mongodb/internal/connection/OidcAuthenticationProseTests.java	Updated to use InternalMongoClients with recordEverything enabled; removed static setup/teardown
driver-reactive-streams/src/test/functional/com/mongodb/reactivestreams/client/ClientSideOperationTimeoutProseTest.java	Implemented createMongoClientWithInternalSettings method for reactive client
driver-reactive-streams/src/test/functional/com/mongodb/reactivestreams/client/AbstractClientMetadataProseTest.java	Updated to use InternalMongoClients with recordEverything enabled
driver-reactive-streams/src/test/functional/com/mongodb/reactivestreams/client/syncadapter/SyncMongoClient.java	Added constructor accepting reactive MongoClient for wrapping
driver-sync/src/test/unit/com/mongodb/client/internal/InternalMongoClientsTest.java	New unit tests for InternalMongoClients functionality
driver-reactive-streams/src/test/unit/com/mongodb/reactivestreams/client/internal/InternalMongoClientsTest.java	New unit tests for reactive InternalMongoClients
driver-core/src/test/functional/com/mongodb/internal/connection/TestCommandListener.java	Updated javadoc reference from static method to builder method
driver-core/src/test/functional/com/mongodb/internal/connection/SingleServerClusterTest.java	Updated to use InternalMongoClientSettings.getDefaults()
driver-core/src/test/functional/com/mongodb/internal/connection/CommandHelperSpecification.groovy	Updated to pass recordEverything parameter to InternalStreamConnectionFactory
driver-core/src/test/functional/com/mongodb/ClusterFixture.java	Updated to use InternalMongoClientSettings.getDefaults()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

driver-sync/src/test/unit/com/mongodb/client/internal/InternalMongoClientsTest.java

…MongoClientsTest.java Co-authored-by: Copilot <[email protected]>

rozza

A couple of nits and a couple of questions.

Looking much cleaner though.

rozza · 2026-02-03T13:02:07Z

driver-core/src/main/com/mongodb/internal/InternalMongoClientSettings.java

+ * Used for testing and internal configuration purposes.
+ *
+ * <p>This class is not part of the public API and may be removed or changed at any time</p>
+ */


Suggested change

*/

* @since 5.7

*/

rozza · 2026-02-03T13:14:16Z

driver-core/src/main/com/mongodb/internal/InternalMongoClientSettings.java

+     *
+     * @return the default settings
+     */
+    public static InternalMongoClientSettings getDefaults() {


I think this might be a new pattern, so I'm hesitant to add it.

As its an internal class and its immutable just make the static public. Thats the pattern we use with TimeoutSettings.DEFAULT.

rozza · 2026-02-03T13:14:29Z

driver-core/src/main/com/mongodb/internal/InternalMongoClientSettings.java

+@Immutable
+public final class InternalMongoClientSettings {
+
+    private static final InternalMongoClientSettings DEFAULTS = builder().build();


See comment below regarding #getDefaults

Suggested change

private static final InternalMongoClientSettings DEFAULTS = builder().build();

public static final InternalMongoClientSettings DEFAULT = builder().build();

rozza · 2026-02-03T13:18:31Z

...ctive-streams/src/main/com/mongodb/reactivestreams/client/internal/InternalMongoClients.java

+ * Internal factory for MongoClient instances.
+ *
+ * <p>This class is not part of the public API and may be removed or changed at any time</p>
+ */


Suggested change

*/

* @since 5.7

*/

rozza · 2026-02-03T13:20:20Z

driver-reactive-streams/src/main/com/mongodb/reactivestreams/client/MongoClients.java

 */
 public final class MongoClients {

+    private static final InternalMongoClientSettings DEFAULT_INTERNAL_SETTINGS = InternalMongoClientSettings.getDefaults();


Looks like we could just use this in InternalMongoClients and keep usage in the internal namespace.

rozza · 2026-02-03T13:22:35Z

...eams/src/test/functional/com/mongodb/reactivestreams/client/syncadapter/SyncMongoClient.java

+     * @param reactiveMongoClient the reactive MongoClient to wrap
+     */
+    public SyncMongoClient(final com.mongodb.reactivestreams.client.MongoClient reactiveMongoClient) {
+        this.connectionPoolCounter = new ConnectionPoolCounter();


This doesn't ensure the connectionPoolCounter is applied to the connection pool listener. Could that be an issue?

rozza · 2026-02-03T13:23:55Z

driver-sync/src/main/com/mongodb/client/MongoClients.java

 */
 public final class MongoClients {

+    private static final InternalMongoClientSettings DEFAULT_INTERNAL_SETTINGS = InternalMongoClientSettings.getDefaults();


See comment regarding this in the reactive streams version.

rozza · 2026-02-03T13:26:04Z

driver-sync/src/test/functional/com/mongodb/client/ClientMetadataProseTest.java

                                            final MongoClientSettings mongoClientSettings) {
-        return MongoClients.create(mongoClientSettings, mongoDriverInformation);
+        return InternalMongoClients.create(mongoClientSettings, mongoDriverInformation,
+                InternalMongoClientSettings.builder().recordEverything(true).build());


Should this be done via a test flag: -Dorg.mongo.test.recordEverything?

Probably not - could be an option in the future if needed.

Replace static recordEverything with instance-based InternalMongoClie…

37b2edb

…ntSettings configuration

nhachicha self-assigned this Jan 19, 2026

nhachicha requested a review from Copilot January 19, 2026 14:20

Copilot AI reviewed Jan 19, 2026

View reviewed changes

driver-sync/src/test/unit/com/mongodb/client/internal/InternalMongoClientsTest.java Outdated Show resolved Hide resolved

nhachicha and others added 2 commits January 19, 2026 14:55

Update driver-sync/src/test/unit/com/mongodb/client/internal/Internal…

482b31a

…MongoClientsTest.java Co-authored-by: Copilot <[email protected]>

moved InternalMongoClientSettings package

95a53b2

nhachicha marked this pull request as ready for review January 19, 2026 16:11

nhachicha requested a review from a team as a code owner January 19, 2026 16:12

nhachicha requested review from rozza and stIncMale January 19, 2026 16:12

rozza requested changes Feb 3, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[JAVA-6060] Reduce global state by grouping internal settings#1864

[JAVA-6060] Reduce global state by grouping internal settings#1864
nhachicha wants to merge 3 commits intomongodb:mainfrom
nhachicha:nh/settings_refactor

nhachicha commented Jan 19, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

rozza left a comment

Uh oh!

rozza Feb 3, 2026

Uh oh!

rozza Feb 3, 2026

Uh oh!

rozza Feb 3, 2026

Uh oh!

rozza Feb 3, 2026

Uh oh!

rozza Feb 3, 2026

Uh oh!

rozza Feb 3, 2026

Uh oh!

rozza Feb 3, 2026

Uh oh!

rozza Feb 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	private static final InternalMongoClientSettings DEFAULTS = builder().build();
	public static final InternalMongoClientSettings DEFAULT = builder().build();

Conversation

nhachicha commented Jan 19, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

rozza left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants