chore: bump the vitest group with 2 updates#795
Open
dependabot[bot] wants to merge 1 commit intomainfrom
Open
Conversation
50b6a52 to
7ca0a70
Compare
7ca0a70 to
a60496d
Compare
a60496d to
d21fd03
Compare
d21fd03 to
9b1d078
Compare
Bumps the vitest group with 2 updates: [@cloudflare/vitest-pool-workers](https://github.com/cloudflare/workers-sdk/tree/HEAD/packages/vitest-pool-workers) and [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest). Updates `@cloudflare/vitest-pool-workers` from 0.10.1 to 0.12.1 - [Release notes](https://github.com/cloudflare/workers-sdk/releases) - [Changelog](https://github.com/cloudflare/workers-sdk/blob/main/packages/vitest-pool-workers/CHANGELOG.md) - [Commits](https://github.com/cloudflare/workers-sdk/commits/@cloudflare/vitest-pool-workers@0.12.1/packages/vitest-pool-workers) Updates `vitest` from 3.2.4 to 4.0.16 - [Release notes](https://github.com/vitest-dev/vitest/releases) - [Commits](https://github.com/vitest-dev/vitest/commits/v4.0.16/packages/vitest) --- updated-dependencies: - dependency-name: "@cloudflare/vitest-pool-workers" dependency-version: 0.12.1 dependency-type: direct:development update-type: version-update:semver-minor dependency-group: vitest - dependency-name: vitest dependency-version: 4.0.16 dependency-type: direct:development update-type: version-update:semver-major dependency-group: vitest ... Signed-off-by: dependabot[bot] <support@github.com>
9b1d078 to
626307e
Compare
Comment on lines
+38
to
39
| "vitest": "^4.0.18", | ||
| "wrangler": "^4.51.0" |
There was a problem hiding this comment.
Bug: The update to vitest ^4.0.18 violates the peer dependency of @cloudflare/vitest-pool-workers, which only supports vitest up to version 3.2.x, causing test failures.
Severity: CRITICAL
Suggested Fix
Downgrade vitest to a version compatible with @cloudflare/vitest-pool-workers (e.g., ~3.2.4). Alternatively, find and upgrade to a newer version of @cloudflare/vitest-pool-workers that officially supports vitest 4.x, if one is available.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: package.json#L38-L39
Potential issue: The pull request upgrades `vitest` to `^4.0.18`, but the
`@cloudflare/vitest-pool-workers` package at version `0.12.9` explicitly declares a peer
dependency on `vitest` versions `2.0.x - 3.2.x`. This version mismatch constitutes a
peer dependency violation that will lead to runtime failures. When tests are run, the
pool worker initialization will fail because its code is incompatible with the breaking
API changes in `vitest` 4.x. This will break the test suite and block the CI/CD
pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the vitest group with 2 updates: @cloudflare/vitest-pool-workers and vitest.
Updates
@cloudflare/vitest-pool-workersfrom 0.10.1 to 0.12.1Release notes
Sourced from
@cloudflare/vitest-pool-workers's releases.... (truncated)
Changelog
Sourced from
@cloudflare/vitest-pool-workers's changelog.... (truncated)
Commits
455361bVersion Packages (#11819)f978609Version Packages (#11700)6a05b1cchore(deps): update zod from ^3.22.3 to ^3.25.76 (#11493)eac5cf7[Workflows/vitest-pool-workers] Add a test handler to get the result of a wor...1223663fix(vitest-pool-workers): auto-find available inspector port when default is ...6be9321Version Packages (#11666)8ba87a0Version Packages (#11602)8d9003esupportctx.exportsin vitest-pool-workers (#11533)d9eae49Version Packages (#11538)8672321Version Packages (#11511)Updates
vitestfrom 3.2.4 to 4.0.16Release notes
Sourced from vitest's releases.
... (truncated)
Commits
b46d744chore: release v4.0.1684a3062fix(browser): string formatting bug when including placeholders in console.lo...f7f6aa8fix: log deprecatedtest.poolOptionsif it's set (#9226)568513cfix: allow inlining fully dynamic import (#9137)5d26b87fix(experimental): exportsetupEnvironmentfor custom pools (#9187)f17eb42refactor: avoid usingisFileServingAllowedfrom Vite (#9160)78cfbf9fix: avoid crashing onprocess.versionsstub (#9174)da0ade2fix: fix browser mode default testTimeout back to 15 seconds (#9167)eb1abf0chore: release v4.0.15a68f74efeat(cache): add opt-out on a plugin level, fix internal root cache (#9154)Maintainer changes
This version was pushed to npm by [GitHub Actions](https://www.npmjs.com/~GitHub Actions), a new releaser for vitest since your current version.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditions