Add CustomDataStore.Exists, alongside helper method on Player#98
Closed
xCynDev wants to merge 1 commit intonorthwood-studios:masterfrom
Closed
Add CustomDataStore.Exists, alongside helper method on Player#98xCynDev wants to merge 1 commit intonorthwood-studios:masterfrom
xCynDev wants to merge 1 commit intonorthwood-studios:masterfrom
Conversation
Contributor
|
Could you make a PR towards #77 (data-store-performance) instead? That way you'd still be credited instead of me re-implementing your changes into my PR |
Contributor
Author
|
Will do! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
CustomDataStore.Exists(), which allows you to check if aCustomDataStoreinstance exists on the givenPlayer, without creating one likeCustomDataStore.GetOrAdd()would.Since there currently is no way to check for that, I figured I'd make a PR.
It also adds
CustomDataStore<TStore>.Exists()andPlayer.HasDataStore<TStore>()as helper methods.