Skip to content

Conversation

@EmanAbdelhaleem
Copy link
Contributor

@EmanAbdelhaleem EmanAbdelhaleem commented Jan 7, 2026

Fixes #1622
Depends on #1576
Related to: #1575

Details

This PR implements EstimationProcedures resource, and refactor its existing functions

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 48.09028% with 299 lines in your changes missing coverage. Please review.
✅ Project coverage is 52.24%. Comparing base (99928f8) to head (f8c4791).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
openml/_api/clients/http.py 40.10% 112 Missing ⚠️
openml/_api/resources/base/versions.py 24.13% 66 Missing ⚠️
openml/_api/resources/tasks.py 21.27% 37 Missing ⚠️
openml/_api/resources/base/fallback.py 24.32% 28 Missing ⚠️
openml/_api/resources/estimation_procedures.py 54.00% 23 Missing ⚠️
openml/testing.py 48.71% 20 Missing ⚠️
openml/_api/runtime/core.py 83.33% 5 Missing ⚠️
openml/_api/resources/base/base.py 86.20% 4 Missing ⚠️
openml/_api/resources/datasets.py 77.77% 2 Missing ⚠️
openml/_api/__init__.py 75.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1604      +/-   ##
==========================================
- Coverage   52.75%   52.24%   -0.52%     
==========================================
  Files          36       50      +14     
  Lines        4333     4881     +548     
==========================================
+ Hits         2286     2550     +264     
- Misses       2047     2331     +284     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@geetu040 geetu040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. The implementation is clean and nicely decoupled. The next step should be adding tests, but let's wait until we have a clearer roadmap for that.
Also, please update the PR description to follow this format:

Fixes #...
Depends on #1576
Related to #1575

@geetu040 geetu040 mentioned this pull request Jan 9, 2026
25 tasks
Copy link
Collaborator

@geetu040 geetu040 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please take a look at the function _get_estimation_procedure_list in tasks/functions and see if it can also be replaced via the list method or a new method in EstimationProcedures class?

@EmanAbdelhaleem EmanAbdelhaleem force-pushed the estimation-procedures-mig branch from 2f6aa34 to 94d1163 Compare January 28, 2026 05:58
@EmanAbdelhaleem EmanAbdelhaleem force-pushed the estimation-procedures-mig branch from 74365bb to 7238714 Compare January 29, 2026 11:17
@EmanAbdelhaleem
Copy link
Contributor Author

@geetu040 I get this assertion error for the matching test:

>       assert output_v1 == output_v2
E       AssertionError: assert ['10-fold Cro...out set', ...] == ['10-fold Cro...out set', ...]
E
E         At index 28 diff: '3-fold Crossvalidation' != '10-fold Crossvalidation'
E         Right contains 3 more items, first extra item: '10% Holdout set'
E         Use -v to get more diff

tests\test_api\test_estimation_procedures.py:107: AssertionError

When trying to check the 2 endpoints, there is really a difference in the returned response, the json response has 3 more estimation procedures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] V1 → V2 API Migration - estimation procedures

4 participants