-
-
Notifications
You must be signed in to change notification settings - Fork 213
[ENH] V1 → V2 API Migration - estimation procedures #1604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[ENH] V1 → V2 API Migration - estimation procedures #1604
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1604 +/- ##
==========================================
- Coverage 52.75% 52.24% -0.52%
==========================================
Files 36 50 +14
Lines 4333 4881 +548
==========================================
+ Hits 2286 2550 +264
- Misses 2047 2331 +284 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
geetu040
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. The implementation is clean and nicely decoupled. The next step should be adding tests, but let's wait until we have a clearer roadmap for that.
Also, please update the PR description to follow this format:
Fixes #...
Depends on #1576
Related to #1575
geetu040
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please take a look at the function _get_estimation_procedure_list in tasks/functions and see if it can also be replaced via the list method or a new method in EstimationProcedures class?
2f6aa34 to
94d1163
Compare
74365bb to
7238714
Compare
for more information, see https://pre-commit.ci
|
@geetu040 I get this assertion error for the matching test: When trying to check the 2 endpoints, there is really a difference in the returned response, the json response has 3 more estimation procedures. |
Fixes #1622
Depends on #1576
Related to: #1575
Details
This PR implements
EstimationProceduresresource, and refactor its existing functions