Skip to content

Conversation

@EmanAbdelhaleem
Copy link
Contributor

@EmanAbdelhaleem EmanAbdelhaleem commented Jan 20, 2026

Fixes #1625
Depends on #1576
Related to #1575

Details
This PR implements Setups resource, and refactor its existing functions

@codecov-commenter
Copy link

codecov-commenter commented Jan 20, 2026

Codecov Report

❌ Patch coverage is 59.57096% with 245 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.88%. Comparing base (99928f8) to head (8c23ab8).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
openml/_api/clients/http.py 59.89% 75 Missing ⚠️
openml/_api/resources/base/versions.py 24.13% 66 Missing ⚠️
openml/_api/resources/tasks.py 21.27% 37 Missing ⚠️
openml/_api/resources/base/fallback.py 24.32% 28 Missing ⚠️
openml/_api/resources/setups.py 72.97% 20 Missing ⚠️
openml/setups/functions.py 40.00% 6 Missing ⚠️
openml/_api/runtime/core.py 83.33% 5 Missing ⚠️
openml/_api/resources/base/base.py 86.20% 4 Missing ⚠️
openml/_api/resources/datasets.py 77.77% 2 Missing ⚠️
openml/_api/__init__.py 75.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1619      +/-   ##
==========================================
- Coverage   52.75%   45.88%   -6.88%     
==========================================
  Files          36       50      +14     
  Lines        4333     4888     +555     
==========================================
- Hits         2286     2243      -43     
- Misses       2047     2645     +598     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@geetu040 geetu040 mentioned this pull request Jan 21, 2026
25 tasks
@EmanAbdelhaleem EmanAbdelhaleem marked this pull request as ready for review January 21, 2026 23:13
@EmanAbdelhaleem
Copy link
Contributor Author

@geetu040 Can you please check if there is something wrong in the get method?
For some reason when I remove the caching from the method in setups/functions and rely on my implementation for the migrated api call, it doesn't work as I receive an HTML not XML response. Although it works fine on the original get_setup method in setups/functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ENH] V1 → V2 API Migration - setups

4 participants