🐛 Fix deprecation conditions showing install errors and improve condition semantics

[camilamacedo86]

Fixes deprecation conditions showing install errors instead of actual deprecation status.

Problems Fixed

1. Install errors leaked into deprecation conditions

When installation failed, the error appeared in ALL conditions including deprecation ones:

- type: PackageDeprecated
  status: "False"
  reason: Failed
  message: "validating bundle: dependency not supported"  # ❌ Wrong place!

Users couldn't tell if something was actually deprecated.

2. Wrong bundle checked during upgrades

When upgrading v1.0.0 → v1.0.1, deprecation showed v1.0.1's status even when the upgrade failed.

This violates Kubernetes convention: status must show actual state, not desired state.

---

Changes Made

What we do now

Situation	What we show
IS deprecated	Condition with status: True
NOT deprecated	Condition absent (no clutter!)
Can't check catalog	Condition with status: Unknown
No bundle installed	BundleDeprecated shows status: Unknown, reason: Absent

Key improvements

1. Install errors stay separate

   • Errors → Progressing and Installed conditions only
   • Deprecation → catalog data only (never errors)

2. Use installed bundle (not resolved)

   • Checks what's actually running
   • Follows Kubernetes "status = actual state" convention

3. Correct reason values

   • Deprecated → when True
   • DeprecationStatusUnknown → when Unknown
   • Absent → when no bundle installed (BundleDeprecated only)

---

Before/After Comparison

What Changed	Main (Before)	This PR (After)
Install errors	Leak into deprecation conditions ❌	Stay in Progressing/Installed only ✅
Catalog unavailable	Shows False (misleading) ❌	Shows Unknown (honest) ✅
Bundle reference	Uses resolved bundle ❌	Uses installed bundle ✅
Reason values	Always Deprecated ❌	Context-specific ✅

---

Examples

Example 1: Install Error (Bug #2008)

Before:

- type: Progressing
  status: "True"
  message: "validation failed: dependency not supported"
- type: PackageDeprecated
  status: "False"
  reason: Failed
  message: "validation failed: dependency not supported"  # ❌ Error leaked!

After:

- type: Progressing
  status: "True"
  message: "validation failed: dependency not supported"
# ✅ PackageDeprecated absent (error didn't leak!)

Example 2: Catalog Removed

Before:

- type: BundleDeprecated
  status: "False"              # ❌ Misleading: claims "not deprecated"
  reason: Failed

After:

- type: BundleDeprecated
  status: "Unknown"            # ✅ Honest: we can't check
  reason: DeprecationStatusUnknown
  message: "deprecation status unknown: catalog data unavailable"

[netlify]

✅ Deploy Preview for olmv1 ready!

Name	Link
🔨 Latest commit	c6fd300
🔍 Latest deploy log	https://app.netlify.com/projects/olmv1/deploys/69728fe6a7340c0008d0886d
😎 Deploy Preview	https://deploy-preview-2296--olmv1.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[Copilot]

Pull Request Overview

This PR refactors deprecation status handling in ClusterExtension reconciliation to ensure deprecation conditions accurately reflect catalog data and installed bundle state, preventing install/validation errors from leaking into deprecation conditions.

• Moved deprecation status updates to a deferred function that runs at the end of reconciliation
• Changed BundleDeprecated condition to use Unknown status with ReasonAbsent when no bundle is installed
• Updated test expectations to handle multiple possible error messages for sourceType validation

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File	Description
internal/operator-controller/controllers/clusterextension_controller.go	Refactored deprecation status logic with deferred updates and new condition semantics for uninstalled bundles
internal/operator-controller/controllers/clusterextension_controller_test.go	Added tests for deprecation handling with resolution failures and applier failures; updated test expectations for BundleDeprecated conditions
test/e2e/cluster_extension_install_test.go	Updated e2e tests to verify deprecation conditions in success and failure scenarios
internal/operator-controller/controllers/clusterextension_admission_test.go	Enhanced sourceType validation test to handle multiple possible error message formats

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[codecov]

Codecov Report

❌ Patch coverage is 99.40476% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.02%. Comparing base (6e4f192) to head (c6fd300).

Files with missing lines	Patch %	Lines
...er/controllers/clusterextension_reconcile_steps.go	96.15%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2296      +/-   ##
==========================================
+ Coverage   69.48%   74.02%   +4.53%     
==========================================
  Files         101      101              
  Lines        7891     7991     +100     
==========================================
+ Hits         5483     5915     +432     
+ Misses       1969     1626     -343     
- Partials      439      450      +11     

Flag	Coverage Δ
e2e	46.83% <67.26%> (-0.15%)	⬇️
experimental-e2e	54.74% <71.42%> (+41.09%)	⬆️
unit	57.65% <98.80%> (+0.60%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[Copilot]

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

internal/operator-controller/controllers/clusterextension_controller_test.go:1

• The assertion require.Contains(ct, []string{...}, cond.Reason) is semantically backwards. The Contains function expects a slice as the second argument and the search item as the first. This should be require.Contains(ct, cond.Reason, []string{ocv1.ReasonFailed, ocv1.ReasonAbsent}) or use require.True(ct, slices.Contains([]string{ocv1.ReasonFailed, ocv1.ReasonAbsent}, cond.Reason)).

package controllers_test

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull Request Overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[camilamacedo86]

/hold

We will need to change here to set False always we should always set something

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[camilamacedo86]

/hold cancel

Changed to keep Deprecated False as before.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 15 out of 15 changed files in this pull request and generated no new comments.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.