Added more functions to calculator, updated UI, and created tests #69
Open
naaimaqadeer wants to merge 4 commits intopH-7:masterfrom
Open
Added more functions to calculator, updated UI, and created tests #69naaimaqadeer wants to merge 4 commits intopH-7:masterfrom
naaimaqadeer wants to merge 4 commits intopH-7:masterfrom
Conversation
Owner
|
@naaimaqadeer Thank you so much for your contribution! Would you mind giving me further details about your PR and the reason for it? Thank you! |
Owner
|
Happy new year @naaimaqadeer! Anytime, if you coud let me know 😄 |
Owner
@naaimaqadeer Let me know if you have the change to get back to me 🙂 |
Owner
|
Let me know if you need any help @naaimaqadeer 🙂 Hopefully what I suggested makes sense to you 😊 |
Owner
|
Hey @naaimaqadeer 🙂 Are you are still willing to finish this and get your PR merged? If not, I will close it. |
|
Greetings,may i have my commit reviewed by someone?Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.