Open
Conversation
|
What's with this "feat:" prefix here and on the other PR? Is this some kind of convention? We certainly don't use that here.
|
Member
|
@derickr, we also don't pose as @php-pulls. ;) I find the rest of the commit message more concerning, anyway. For a moment that sounded like a bereavment. @Tyrael, I'm fine with the removal, but it doesn't matter much nowadays, since the bug tracker does no longer accept new tickets for a while. |
Member
|
I don't want to pose as that. I reply from my github registered email address and sometimes it comes up as php-pulls, and sometimes as derickr. I've no idea why :-/
|
Member
|
Yes, I know. No worries. :) Personally, I find these tags ("feat", "chore", etc.) more than useless if not consitently applied, but I don't really mind (I see the old "MFH" commits all the time; that's worse). |
Contributor
Author
|
yeah it's called Conventional Commits, nowadays I have the habbit of using them, I can reword the commit message, but you can also just squash it with whatever commit message you prefer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
remove myself from the list of trusted devs as I'm not contributing anymore