fix: add missing sessionTolerations property to Helm Site CRD #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Helm Chart Review (dist/chart/)
- Values have sensible defaults — N/A (CRD schema only)
- Templates render correctly — Schema addition is well-formed
- RBAC permissions are minimal — N/A
- CRDs are up to date — ✅ Verified:
sessionTolerationsdefinition matches the base CRD atconfig/crd/bases/core.posit.team_sites.yaml:1319-1358exactly
This is a clean, targeted fix that brings the Helm CRD in sync with the base CRD for the sessionTolerations field. The schema correctly defines the Kubernetes Toleration structure with all expected properties (effect, key, operator, tolerationSeconds, value).
Author
|
How are we handling version bumps by the way? Didn't see any guidance in CONTRIBUTING, so I haven't done anything here yet. |
amdove
approved these changes
Jan 29, 2026
Author
|
Closing in favor of #60 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Helm CRDs have drifted from the base CRDs, and
sessionTolerationsis missing from the Helm CRDs. This resolves the issue specifically forsessionTolerations. This PR uses the generated site CRD from runningjust helm-generate, but it prunes all unrelated changes as outlined in #57.Related to #57