Test: Bidder removal fields #4329

marki1an · 2025-12-31T11:05:55Z

🔧 Type of changes

✨ What's the context?

What's the context for the changes?

🧠 Rationale behind the change

Why did you choose to make these changes? Were there any trade-offs you had to consider?

🔎 New Bid Adapter Checklist

verify email contact works
NO fully dynamic hostnames
geographic host parameters are NOT required
direct use of HTTP is prohibited - implement an existing Bidder interface that will do all the job
if the ORTB is just forwarded to the endpoint, use the generic adapter - define the new adapter as the alias of the generic adapter
cover an adapter configuration with an integration test

🧪 Test plan

How do you know the changes are safe to ship to production?

🏎 Quality check

Are your changes following our code style guidelines?
Are there any breaking changes in your code?
Does your test coverage exceed 90%?
Are there any erroneous console logs, debuggers or leftover code in your changes?

`<launchContainers>false</launchContainers>`

osulzhenko

Additionally, we must ensure that the value is exposed only to the specified bidder. Please add test cases involving multiple bidders to verify fields:

ext.prebid.bidadjustmentfactors
ext.prebid.bidadjustments
ext.prebid.multibid
ext.prebid.alternatebiddercodes

osulzhenko · 2026-01-06T15:45:28Z

src/test/groovy/org/prebid/server/functional/tests/AuctionSpec.groovy

 import org.prebid.server.functional.service.PrebidServerService
 import org.prebid.server.functional.util.HttpUtil
 import org.prebid.server.functional.util.PBSUtils
+import spock.lang.IgnoreRest


osulzhenko · 2026-01-06T17:28:30Z

src/test/groovy/org/prebid/server/functional/tests/privacy/GppTransmitTidActivitiesSpec.groovy

+        and: "Bidder request should contain ext.prebid.creativeTids"
+        assert bidderRequest.ext.prebid.createTids
+


privacy package is not the best place to verify this field

osulzhenko · 2026-01-07T09:51:59Z

src/test/groovy/org/prebid/server/functional/tests/NativeSpec.groovy

@@ -1,5 +1,6 @@
 package org.prebid.server.functional.tests

+import org.prebid.server.functional.model.bidderspecific.BidderRequest


dead import

osulzhenko · 2026-01-07T09:58:49Z

src/test/groovy/org/prebid/server/functional/tests/BidderFieldDisplayBehaviorSpec.groovy

+        def bidderRequest = bidder.getBidderRequest(bidRequest.id)
+        assert !bidderRequest.user.ext.prebid.buyeruids
+
+        and: "Bidder request should contain fcapid,time,consentedProvidedSettings"


and: "Bidder request should contain user.ext.{fcapid,time,consentedProvidersSettings}"

osulzhenko · 2026-01-07T10:09:46Z

src/test/groovy/org/prebid/server/functional/tests/BidderFieldDisplayBehaviorSpec.groovy

+
+        then: "Bidder request should contain requested amp"
+        def bidderRequest = bidder.getBidderRequest(bidRequest.id)
+        assert bidderRequest.ext.prebid.amp


assert bidderRequest.ext.prebid.amp == bidRequest.ext.prebid.amp

same for others

osulzhenko · 2026-01-07T10:27:44Z

src/test/groovy/org/prebid/server/functional/tests/BidderFieldDisplayBehaviorSpec.groovy

+                            key = "custom_bid_request"
+                            source = "bidrequest"
+                            value = "imp.id"


make it constant or variables or random values, it's looks like magic numbers

osulzhenko · 2026-01-07T10:28:59Z

src/test/groovy/org/prebid/server/functional/tests/BidderFieldDisplayBehaviorSpec.groovy

+        assert bidderRequest.ext.prebid.trace
+        assert bidderRequest.ext.prebid.debug
+        assert bidderRequest.ext.prebid.integration


replace with verifyAll and confirm that equals to bidRequest

osulzhenko · 2026-01-07T10:34:35Z

src/test/groovy/org/prebid/server/functional/tests/BidderFieldDisplayBehaviorSpec.groovy

+        assert bidderRequest.ext.prebid.amp
+    }
+
+    def "PBS shouldn't pass ext.prebid.analytics to bidder request when analytics specified"() {


we can use for this check: PBS should populate log analytics with additional data when log is directly non-restricted for account and data specified

osulzhenko · 2026-01-07T10:35:49Z

src/test/groovy/org/prebid/server/functional/tests/BidderFieldDisplayBehaviorSpec.groovy

+        assert bidderRequest.ext.prebid.sdk.renderers.name == bidRequest.ext.prebid.sdk.renderers.name
+        assert bidderRequest.ext.prebid.sdk.renderers.version == bidRequest.ext.prebid.sdk.renderers.version
+        assert bidderRequest.ext.prebid.sdk.renderers.data.any == bidRequest.ext.prebid.sdk.renderers.data.any


replace with verifyAll

osulzhenko · 2026-01-07T10:39:39Z

src/test/groovy/org/prebid/server/functional/tests/BidderFieldDisplayBehaviorSpec.groovy

+        assert bidderRequest.user.ext.fcapids == bidRequest.user.ext.fcapids
+        assert bidderRequest.user.ext.time == bidRequest.user.ext.time
+        assert bidderRequest.user.ext.consentedProvidersSettings == bidRequest.user.ext.consentedProvidersSettings


…ional-tests/remove-redundat-fields-from-bidderrequest

…ional-tests/remove-redundat-fields-from-bidderrequest # Conflicts: # src/main/java/org/prebid/server/auction/bidderrequestpostprocessor/BidderRequestCleaner.java # src/main/java/org/prebid/server/auction/bidderrequestpostprocessor/BidderRequestCurrencyBlocker.java # src/main/java/org/prebid/server/auction/bidderrequestpostprocessor/BidderRequestMediaFilter.java # src/main/java/org/prebid/server/auction/bidderrequestpostprocessor/BidderRequestPostProcessor.java # src/main/java/org/prebid/server/auction/bidderrequestpostprocessor/BidderRequestPreferredMediaProcessor.java # src/main/java/org/prebid/server/auction/bidderrequestpostprocessor/CompositeBidderRequestPostProcessor.java # src/main/java/org/prebid/server/spring/config/ServiceConfiguration.java # src/test/java/org/prebid/server/auction/ExchangeServiceTest.java # src/test/java/org/prebid/server/auction/bidderrequestpostprocessor/BidderRequestCleanerTest.java # src/test/java/org/prebid/server/auction/bidderrequestpostprocessor/BidderRequestCurrencyBlockerTest.java # src/test/java/org/prebid/server/auction/bidderrequestpostprocessor/BidderRequestMediaFilterTest.java # src/test/java/org/prebid/server/auction/bidderrequestpostprocessor/BidderRequestPreferredMediaProcessorTest.java # src/test/java/org/prebid/server/auction/bidderrequestpostprocessor/CompositeBidderRequestPostProcessorTest.java

osulzhenko · 2026-01-29T09:29:19Z

src/test/groovy/org/prebid/server/functional/tests/BidderParamsSpec.groovy

 import org.prebid.server.functional.model.response.auction.BidResponse
 import org.prebid.server.functional.util.PBSUtils
 import org.prebid.server.functional.util.privacy.CcpaConsent
+import spock.lang.IgnoreRest


osulzhenko · 2026-01-30T15:17:05Z

src/test/groovy/org/prebid/server/functional/model/request/auction/Prebid.groovy

-    }
+    Boolean supportDeals
+    String integration
+    Map<String, String> bidders


osulzhenko · 2026-01-30T15:33:29Z

src/test/groovy/org/prebid/server/functional/tests/BidAdjustmentSpec.groovy

    def "PBS should prefer bid price adjustment based on media type when request has per-media-type bid adjustment factors"() {
        given: "Default bid request with bid adjustment"
-        def bidAdjustment = randomDecimal
+        def bidAdjustment = roundDecimal(getRandomDecimal(), 0)


Why do we need to round here?

osulzhenko · 2026-01-30T15:40:24Z

src/test/groovy/org/prebid/server/functional/tests/BidderFieldDisplayBehaviorSpec.groovy

+
+    def "PBS should pass ext.prebid.bidAdjustmentFactors only bidder related entry for each bidder"() {
+        given: "Default bid request with bid adjustment"
+        def bidAdjustment = roundDecimal(getRandomDecimal(), 0)


Why do we need to round here?

osulzhenko · 2026-01-30T16:36:21Z

src/test/groovy/org/prebid/server/functional/tests/BidderFieldDisplayBehaviorSpec.groovy

+        assert !bidderRequest?.ext?.prebid?.bidAdjustmentFactors?.mediaTypes[VIDEO]
+
+        where:
+        bidAdjustmentFactor << [0.9, 1.1]


can be change to mediaTypeBidAdjustment

osulzhenko · 2026-01-30T16:47:43Z

src/test/groovy/org/prebid/server/functional/tests/BidderFieldDisplayBehaviorSpec.groovy

+
+        and: "Bidder request should contain user.ext.{fcapid,time,consentedProvidersSettings}"
+        verifyAll(bidderRequest) {
+            bidderRequest.user.ext.fcapids == bidRequest.user.ext.fcapids


verifyAll(bidderRequest.user.ext)

osulzhenko · 2026-01-30T16:48:40Z

src/test/groovy/org/prebid/server/functional/tests/BidderFieldDisplayBehaviorSpec.groovy

+    def "PBS should pass user.ext to bidder request when user.ext specified"() {
+        given: "Default basic BidRequest with generic bidder"
+        def bidRequest = BidRequest.defaultBidRequest.tap {
+            user = new User(ext: new UserExt().tap {


Define UserExt as def

osulzhenko · 2026-01-30T16:49:21Z

src/test/groovy/org/prebid/server/functional/tests/BidderFieldDisplayBehaviorSpec.groovy

+        given: "Default bid request"
+        def bidRequest = BidRequest.defaultBidRequest.tap {
+            ext.prebid.bidderConfig = [new ExtPrebidBidderConfig(bidders: [BidderName.GENERIC], config:
+                    new BidderConfig(ortb2: new BidderConfigOrtb(site: Site.configFPDSite, user: User.configFPDUser)))]


also can be PrebidBidderConfig

osulzhenko · 2026-01-30T16:56:05Z

src/test/groovy/org/prebid/server/functional/tests/BidderFieldDisplayBehaviorSpec.groovy

+        assert !bidderRequest.ext.prebid.bidderConfig
+    }
+
+    def "PBS shouldn't pass bidder param to the bidder when bidder param bidder not requested"() {


It's not that simple. This field depends on ext.prebid.bidders. Verify that it sends the parameter to the specific bidder and ignores others. Ensure the test reflects the PBS logic for correct field mapping

private static Map<String, JsonNode> bidderToPrebidBidders(BidRequest bidRequest) { final ExtRequestPrebid prebid = PbsUtil.extRequestPrebid(bidRequest); final ObjectNode bidders = prebid == null ? null : prebid.getBidders(); if (bidders == null || bidders.isNull()) { return Collections.emptyMap(); } final Map<String, JsonNode> bidderToPrebidParameters = new HashMap<>(); final Iterator<Map.Entry<String, JsonNode>> biddersToParams = bidders.fields(); while (biddersToParams.hasNext()) { final Map.Entry<String, JsonNode> bidderToParam = biddersToParams.next(); bidderToPrebidParameters.put(bidderToParam.getKey(), bidderToParam.getValue()); } return bidderToPrebidParameters;

final JsonNode prebidParameters = bidderToPrebidBidders.get(bidder); final ObjectNode bidders = prebidParameters != null ? mapper.mapper().valueToTree(ExtPrebidBidders.of(prebidParameters)) : null; ... return ExtRequest.of(extPrebidBuilder .multibid(resolveExtRequestMultiBids(bidderToMultiBid.get(bidder), bidder)) .bidders(bidders) .bidderparams(prepareBidderParameters(extPrebid, bidder))

private ObjectNode prepareBidderParameters(ExtRequestPrebid prebid, String bidder) { final ObjectNode bidderParams = prebid != null ? prebid.getBidderparams() : null; final JsonNode params = bidderParams != null ? bidderParams.get(bidder) : null; return params != null ? mapper.mapper().createObjectNode().set(bidder, params) : null; }

osulzhenko · 2026-01-30T16:58:30Z

src/test/groovy/org/prebid/server/functional/tests/BidderFieldDisplayBehaviorSpec.groovy

+    def "PBS shouldn't pass ext.prebid.data.{bidders,eidpermissions} to bidder request"() {
+        given: "Default bid request"
+        def bidRequest = BidRequest.defaultBidRequest.tap {
+            ext.prebid.data = new ExtRequestPrebidData(bidders: [GENERIC.value],


you are using ErrorType.GENERIC

marki1an and others added 6 commits December 5, 2025 14:46

Update: Remove unnecessary metics checks

7e4ce74

Update: Add coverage for bidder removal fields

1233b6c

Refactor MediaTypeProcessor

5ca717c

Update: Add coverage for bidder removal fields

c32bcc2

Remove not expected fields from bidder request

e73a6b0

Add more coverage for bidder removal fields

34d4433

marki1an self-assigned this Dec 31, 2025

marki1an added the tests Functional or other tests label Dec 31, 2025

Replace to false

3b9796c

`<launchContainers>false</launchContainers>`

osulzhenko self-requested a review January 2, 2026 14:18

Add units

0f62f16

osulzhenko requested changes Jan 7, 2026

View reviewed changes

marki1an and others added 3 commits January 8, 2026 11:53

Merge remote-tracking branch 'origin/clean-bidder-request' into funct…

7f5f79e

…ional-tests/remove-redundat-fields-from-bidderrequest

Fix bug

1bb910d

Update after review

ea0c3c0

marki1an changed the base branch from master to clean-bidder-request January 8, 2026 15:14

marki1an added 4 commits January 8, 2026 18:02

Merge remote-tracking branch 'origin/clean-bidder-request' into funct…

1f171a9

…ional-tests/remove-redundat-fields-from-bidderrequest

Update targeting

15cdd97

Update after review

f55bd7b

Add coverage for ext?.prebid?.bidAdjustmentFactors?.mediaTypes

dc3d8e6

CTMBNara force-pushed the clean-bidder-request branch from 1bb910d to ea8225a Compare January 15, 2026 12:55

osulzhenko requested changes Jan 30, 2026

View reviewed changes

		and: "Bidder request should contain ext.prebid.creativeTids"
		assert bidderRequest.ext.prebid.createTids

		@@ -1,5 +1,6 @@
		package org.prebid.server.functional.tests

		import org.prebid.server.functional.model.bidderspecific.BidderRequest

Test: Bidder removal fields #4329

Are you sure you want to change the base?

Test: Bidder removal fields #4329

Conversation

marki1an commented Dec 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔧 Type of changes

✨ What's the context?

🧠 Rationale behind the change

🔎 New Bid Adapter Checklist

🧪 Test plan

🏎 Quality check

Uh oh!

osulzhenko left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

marki1an commented Dec 31, 2025 •

edited

Loading