Channel transport with particles #700
Conversation
|
The We need to rethink how we are distributing solver codes that are built directly in the build tree of the respective solver. A good place to document this then would be the adapter software engineering page. |
|
|
||
| Particle participant: | ||
|
|
||
| * MercuryDPM |
There was a problem hiding this comment.
More information needed here (I know you know, just for the overview).
|  |
There was a problem hiding this comment.
|  | |
|  |
and image missing
| ## Setup | ||
|
|
||
| We model a two-dimensional incompressible fluid flowing through a channel with an obstacle. The fluid problem is coupled to a particle participant for particle tracing. Similar to the transport problem (see the [channel-transport tutorial](tutorials-channel-transport.html)), particles are arranged in a circular blob close to the inflow. | ||
|
|
There was a problem hiding this comment.
You could add here the very nice picture from the PR description.
We could add a Do we also need a cleaning script there? |
| --- | ||
|
|
||
| {% note %} | ||
| Get the [case files of this tutorial](https://github.com/precice/tutorials/tree/master/channel-transport-particles). Read how in the [tutorials introduction](https://precice.org/tutorials.html). |
There was a problem hiding this comment.
How does this fit to the information here https://precice.org/tutorials.html ?
at the very top?
There was a problem hiding this comment.
Are you asking if the following statement needs to be revised?
You can find all tutorial case files in the tutorials repository. Get the latest release, or clone the Git repository to easily update them in the future:
Since the default branch is develop, this is fine as-is. I can make this more explicit next time I edit that page.
There was a problem hiding this comment.
If you include one further line further, it becomes
You can find all tutorial case files in the [tutorials repository](https://github.com/precice/tutorials). Get the [latest release](https://github.com/precice/tutorials/releases/latest), or clone the Git repository to easily update them in the future:
git clone --branch=master --depth 1 https://github.com/precice/tutorials.git
Since the default branch is develop, this is fine as-is.
So, the default branch is explicitly overridden!?
There was a problem hiding this comment.
This is the usual question of whether we want the users to see and use the released or the development version.
The default branch is develop, since we want all PRs to target that.
The branch we want users to use has so far been master. In this statement yes, it could be better to skip the --branch=master, since we want people to contribute.
Feel free to submit a PR. In this comment, I just wanted to add a reminder that this has now changed.
There was a problem hiding this comment.
The open question is a bit how to handle the MercuryDPM participant, as the coupled code is entirely compiled with MerucryDPM
https://bitbucket.org/mercurydpm/mercurydpm/pull-requests/266
In principle, using
and copying the executable compiled in
./build/./Drivers/PreCICE/ChannelTransportis sufficient. Afterwards simply execute the case.Checklist:
changelog-entries/<PRnumber>.md.