Skip to content

gh-106318: Add example for str.rindex() method #143887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
vstinner merged 5 commits into from
Feb 3, 2026
Merged

gh-106318: Add example for str.rindex() method #143887

vstinner merged 5 commits into from
Feb 3, 2026

Conversation

@adorilson
Copy link
Contributor

@adorilson adorilson commented Jan 15, 2026 •
edited by github-actions bot
Loading

WIP to #106318

#106318: Add examples for str.rindex() method

📚 Documentation preview 📚: https://cpython-previews--143887.org.readthedocs.build/

@bedevere-app bedevere-app bot added docs Documentation in the Doc dir skip news labels Jan 15, 2026
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs Jan 15, 2026
@bedevere-app bedevere-app bot mentioned this pull request Jan 15, 2026
Open
vstinner
vstinner reviewed Jan 19, 2026
View reviewed changes
Doc/library/stdtypes.rst

.. doctest::

>>> 'spam, spam, spam'.rindex('eggs')
Copy link
Member

@vstinner vstinner Jan 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a successful example, like looking for spam?

Copy link
Contributor Author

@adorilson adorilson Jan 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure.

But I did it this way to be in line with str.index, which doesn't have a successful example.

Should I add it there as well?

Copy link
Member

@vstinner vstinner Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I did it this way to be in line with str.index, which doesn't have a successful example. Should I add it there as well?

Yes, I suggest to also add a successful example in str.index().

Try to use the same input string for both examples.

Copy link
Contributor Author

@adorilson adorilson Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done here.

Copy link
Member

@vstinner vstinner Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You didn't add a successful example to str.index().

Copy link
Contributor Author

@adorilson adorilson Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a new PR: #144408

Copy link
Member

@vstinner vstinner Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't deserve a whole new PR. Please change it in this PR.

Copy link
Contributor Author

@adorilson adorilson Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All done.

@adorilson adorilson mentioned this pull request Feb 3, 2026
Closed
@adorilson adorilson requested a review from vstinner February 3, 2026 10:08
vstinner
vstinner approved these changes Feb 3, 2026
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vstinner
Copy link
Member

vstinner commented Feb 3, 2026

Oh. "Tests / All required checks pass" CI failed with:

Error: The template is not valid. .github/workflows/build.yml (Line: 723, Col: 24): Error reading JToken from JsonReader. Path '', line 0, position 0.

Let me try to update the branch.

@vstinner vstinner enabled auto-merge (squash) February 3, 2026 13:23
@vstinner vstinner added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Feb 3, 2026
@vstinner vstinner merged commit 45d00a0 into python:main Feb 3, 2026
33 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Feb 3, 2026
@miss-islington-app
Copy link

miss-islington-app bot commented Feb 3, 2026

Thanks @adorilson for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2026
@adorilson @vstinner @miss-islington
pythongh-106318: Add examples for str.rindex() method (pythonGH-143887)
0da097e 
(cherry picked from commit 45d00a0)

Co-authored-by: Adorilson Bezerra <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 3, 2026
@adorilson @vstinner @miss-islington
pythongh-106318: Add examples for str.rindex() method (pythonGH-143887)
e20739a 
(cherry picked from commit 45d00a0)

Co-authored-by: Adorilson Bezerra <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app
Copy link

bedevere-app bot commented Feb 3, 2026

GH-144421 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Feb 3, 2026
@bedevere-app
Copy link

bedevere-app bot commented Feb 3, 2026

GH-144422 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Feb 3, 2026
vstinner added a commit that referenced this pull request Feb 3, 2026
@miss-islington @adorilson @vstinner
[3.14] gh-106318: Add examples for str.rindex() method (GH-143887) (#…
cc8fd6a 
…144421)

gh-106318: Add examples for str.rindex() method (GH-143887)
(cherry picked from commit 45d00a0)

Co-authored-by: Adorilson Bezerra <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
vstinner added a commit that referenced this pull request Feb 3, 2026
@miss-islington @adorilson @vstinner
[3.13] gh-106318: Add examples for str.rindex() method (GH-143887) (#…
4482064 
…144422)

gh-106318: Add examples for str.rindex() method (GH-143887)
(cherry picked from commit 45d00a0)

Co-authored-by: Adorilson Bezerra <[email protected]>
Co-authored-by: Victor Stinner <[email protected]>
@vstinner
Copy link
Member

vstinner commented Feb 3, 2026

Merged, thanks.

Aniketsy pushed a commit to Aniketsy/cpython that referenced this pull request Feb 3, 2026
@adorilson @vstinner @Aniketsy
pythongh-106318: Add examples for str.rindex() method (python#143887)
de7cedc 
Co-authored-by: Victor Stinner <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adorilson @vstinner