gh-144023: prevent follow_symlinks from being allowed with an fd of 0 #144022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AZero13
changed the title
AZero13
force-pushed
the
careful
branch
2 times, most recently
from
5e70bef to
b253e1e
Compare
…d of 0 fd_and_follow_symlinks_invalid lets you use fd and follow_symlinks together if fd is 0. This is incorrect, as 0 is a valid fd.
AZero13
changed the title
sobolevn
reviewed
Jan 19, 2026
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Is there any way to test this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fd_and_follow_symlinks_invalid lets you use fd and follow_symlinks together if fd is 0.
This is incorrect, as 0 is a valid fd.