gh-144257: document return values of PyModule_SetDocString#144258
Merged
ZeroIntensity merged 4 commits intopython:mainfrom Jan 27, 2026
Merged
gh-144257: document return values of PyModule_SetDocString#144258ZeroIntensity merged 4 commits intopython:mainfrom
ZeroIntensity merged 4 commits intopython:mainfrom
Conversation
…odule_SetDocString
sobolevn
reviewed
Jan 26, 2026
Co-authored-by: sobolevn <[email protected]>
ngoldbaum
commented
Jan 26, 2026
ngoldbaum
commented
Jan 26, 2026
ngoldbaum
changed the title
sobolevn
approved these changes
Jan 26, 2026
Member
sobolevn
left a comment
sobolevn
left a comment
There was a problem hiding this comment.
Thank you!
I will keep this open for a bit, so others can also take a look :)
And merge it in several days.
ZeroIntensity
approved these changes
Jan 27, 2026
sergey-miryanov
approved these changes
Jan 27, 2026
ZeroIntensity
added
needs backport to 3.13
|
Thanks @ngoldbaum for the PR, and @ZeroIntensity for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 27, 2026
…honGH-144258) (cherry picked from commit 3e9a5b0) Co-authored-by: Nathan Goldbaum <[email protected]> Co-authored-by: sobolevn <[email protected]>
|
Sorry, @ngoldbaum and @ZeroIntensity, I could not cleanly backport this to |
|
GH-144263 is a backport of this pull request to the 3.14 branch. |
Member
|
@ngoldbaum Would you mind handling the 3.13 backport? |
ZeroIntensity
pushed a commit
that referenced
this pull request
Jan 27, 2026
…-144258) (GH-144263) gh-144257: document return values of PyModule_SetDocString (GH-144258) (cherry picked from commit 3e9a5b0) Co-authored-by: Nathan Goldbaum <[email protected]> Co-authored-by: sobolevn <[email protected]>
|
GH-144286 is a backport of this pull request to the 3.13 branch. |
ZeroIntensity
pushed a commit
that referenced
this pull request
Jan 27, 2026
…-144258) (GH-144286) (cherry picked from commit 3e9a5b0) Co-authored-by: sobolevn <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://cpython-previews--144258.org.readthedocs.build/