Don't partition fp16 GeLU on XNNPACK for now #16680
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/16680
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit ebae7bd with merge base 8d29b22 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
bot
added
the
CLA Signed
Contributor
|
@GregoryComer has exported this pull request. If you are a Meta employee, you can view the originating Diff in D90899836. |
GregoryComer
added
the
release notes: xnnpack
mergennachin
approved these changes
Jan 21, 2026
Summary: Older versions of the XNNPACK library don't properly support fp16 GeLU. Disable partitioning until we pull in a newer version of XNNPACK (tracking in pytorch#16679). Differential Revision: D90899836
GregoryComer
force-pushed
the
export-D90899836
branch
from
1ffdc66 to
ebae7bd
Compare
Member
Author
|
Rebasing and re-running CI, since there is a bunch of noise. Will merge once green. |
Contributor
|
@GregoryComer has imported this pull request. If you are a Meta employee, you can view this in D90899836. |
NickJLange
pushed a commit
to NickJLange/executorch
that referenced
this pull request
Jan 21, 2026
Summary: Older versions of the XNNPACK library don't properly support fp16 GeLU. Disable partitioning until we pull in a newer version of XNNPACK (tracking in pytorch#16679). Fixes [pytorch#16672](pytorch#16672). Differential Revision: D90899836
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Older versions of the XNNPACK library don't properly support fp16 GeLU. Disable partitioning until we pull in a newer version of XNNPACK (tracking in #16679).
Fixes #16672.
Differential Revision: D90899836