fix: column-margin with renderings option (#13825)#13903
Open
gordonwoodhull wants to merge 2 commits intomainfrom
Open
fix: column-margin with renderings option (#13825)#13903gordonwoodhull wants to merge 2 commits intomainfrom
gordonwoodhull wants to merge 2 commits intomainfrom
Conversation
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Contributor
Author
|
Confirmed visually - no spatial HTML tests yet! This is one of those cases where the dark mode table is annoyingly about 2px lower. It doesn't always happen but it makes me think the light mode div is taking up a tiny amount of space. (Claude found that it's a bug in our SCSS.) |
Preserve existing classes on cell-output-display divs when applying light/dark theme classes in the cell-renderings filter. Previously, new divs were created that discarded existing classes like column-margin. Co-Authored-By: Claude Opus 4.5 <[email protected]>
Co-Authored-By: Claude Opus 4.5 <[email protected]>
gordonwoodhull
force-pushed
the
fix/13825-column-margin-renderings
branch
from
d341224 to
9925b6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
column: margindoesn't work withrenderings: [light, dark]? #13825 wherecolumn: margindidn't work together withrenderings: [light, dark]column-margin,cell-output-display)light-content/dark-contentclass to themTest plan
tests/docs/smoke-all/dark-mode/renderings-column-margin.qmdthat verifies the fix./run-fast-tests.sh docs/smoke-all/dark-mode/renderings-column-margin.qmd🤖 Generated with Claude Code