feat(website): enhanced control over navbar and sidebar titles (#13477)#13906
Open
jtbayly wants to merge 3 commits intoquarto-dev:mainfrom
Open
feat(website): enhanced control over navbar and sidebar titles (#13477)#13906jtbayly wants to merge 3 commits intoquarto-dev:mainfrom
jtbayly wants to merge 3 commits intoquarto-dev:mainfrom
Conversation
…o-dev#13477) - Allow `navbar.title` and `sidebar.title` to be `boolean` or `string`. - Fix bug where disabling navbar title erroneously hid sidebar title. - Support custom titles for navbar and sidebar. - Add smoke tests for title control options. - Update schema documentation for titling options.
Collaborator
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
…o-dev#13477) - Allow `navbar.title` and `sidebar.title` to be `boolean` or `string`. - Fix bug where disabling navbar title erroneously hid sidebar title. - Support custom titles for navbar and sidebar. - Add smoke tests for title control options. - Update schema documentation for titling options.
Author
|
I did a lot of testing to make sure that every single combination of options works as explained in my proposal on the bug report. I compared screenshots of all the combinations, to make sure that nothing changed except for fixing this bug, and the small feature additions. |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
navbar.titleandsidebar.titleto bebooleanorstring.Checklist
I have (if applicable):