Split domProps into separate subtypes

[dkirchhof]

While building custom jsx transformers or defining bindings for "jsx-libraries" other than react, it could be possible, that some "fields" in domProps has other types as in the core library.

Examples:

• it uses "class" instead of "className"
• style is a string instead of an object
• events are named "click" or "onclick" instead of "onClick"
• ...

So, if you want to add a field, fine. Just extend domProps.
But if you want to change an existing field, you have to create your own type and copy hundreds of existing fields. This is tedious.

---

I splitted the domProps into some subtypes, so it is easier to define your own domProps.
Example:

type customJsxProps = {
  children?: child, // custom type for children
  class?: string, // class instead of className
} 

type customDomProps = {
  ...customJsxProps,
  ...JsxDOM.baseProps,
  ...JsxDOM.events,
  ...JsxDOM.svg,
  style?: string, // string instead of JsxDOMStyle.t
}

---

What do you think?
Is there an easier way?
Does it have performance implications?

[dkirchhof]

Btw:

I tried to fix the failing check by using the analaysis tests, but it didn't change anything.
Steps (using devcontainers cli):

1. devcontainer up --workspace-folder .
2. devcontainer exec --workspace-folder . bash
3. rustup toolchain install 1.91 && rustup override set 1.91 otherwise next commands fail, because rust 1.88 is installed
4. make lib && make build && make test-analysis

The test-analysis command succeeds, but doesn't change anything. So nothing to commit.

[pkg-pr-new]

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@8162

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@8162

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@8162

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@8162

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@8162

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@8162

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@8162

commit: 4aabdb4

[dkirchhof]

Btw:

I tried to fix the failing check by using the analaysis tests, but it didn't change anything. Steps (using devcontainers cli):

1. devcontainer up --workspace-folder .
2. devcontainer exec --workspace-folder . bash
3. rustup toolchain install 1.91 && rustup override set 1.91 otherwise next commands fail, because rust 1.88 is installed
4. make lib && make build && make test-analysis

The test-analysis command succeeds, but doesn't change anything. So nothing to commit.

Updated the container. Now it uses rust 1.92.

[nojaf]

I think idea-wise I like this. It does make me wonder how much of these types should still lives in this repo and not in rescript-react?

Can't say anything on the impact of this change. I hope others can share more insights.

[dkirchhof]

According to the comments, there are just 4 react specific fields. They could be moved to the rescript-react repo and it should be easy to extend the original domProps there.

All other fields are probably from the html5 spec. Theoretically, they would also fit into the experimental-rescript-webapi repo. So library authors (who needs custom jsx stuff) could also benefit from other apis like setAttribute, setAttributeNS, etc.

But I think it would overcomplicate the whole process to create custom jsx transformers.